From: Pekka Enberg <penberg@kernel.org>
To: "Gábor Stefanik" <netrolller.3d@gmail.com>
Cc: Akshay Joshi <me@akshayjoshi.com>, Pavel Machek <pavel@ucw.cz>,
Greg Kroah-Hartman <gregkh@suse.de>,
Karthigan Srinivasan <karthigan.srinivasan2@gmail.com>,
devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond.
Date: Wed, 17 Aug 2011 08:41:56 +0300 [thread overview]
Message-ID: <4E4B54A4.4040203@kernel.org> (raw)
In-Reply-To: <CA+XFjiq01Ea4hivhMK=H3pgFeaoCgUWDUirD=-PzALzvOpdvvA@mail.gmail.com>
On 8/17/11 12:38 AM, Gábor Stefanik wrote:
> 2011/8/16 Pekka Enberg<penberg@kernel.org>:
>> 2011/8/16 Gábor Stefanik<netrolller.3d@gmail.com>:
>>>> -
>>>> -//====================================
>>>> -// Internal variable for module
>>>> -//====================================
>>>> +/*============================================================================
>>>> +/* wb35rx.h --
>>>> +/*============================================================================
>>> I'm pretty sure this is not an accepted kernel comment style.
>> What's the problem? I think it's OK for this particular patch.
>>
> The comments are not even valid C. The only reason why they do not
> break is that they are immediately followed by another,
> correctly-formatted (but separate) comment.
Aah, amazing how I was able to miss that!
Akshay, I suppose you didn't compile-test the patches? Please don't
send patches like that on LKML. It's a huge waste of time for reviewers.
Pekka
next prev parent reply other threads:[~2011-08-17 5:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-16 0:24 [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c Akshay Joshi
2011-08-16 0:24 ` [PATCH 2/9] Staging: Winbond: Fix pointer style in wb35tx.c Akshay Joshi
2011-08-16 5:41 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 3/9] Staging: Winbond: Fix space issues " Akshay Joshi
2011-08-16 5:42 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 4/9] Staging: Winbond: Convert C99 style comments in Winbond Akshay Joshi
2011-08-16 5:42 ` Pekka Enberg
2011-08-16 19:56 ` Gábor Stefanik
2011-08-16 21:24 ` Pekka Enberg
2011-08-16 21:38 ` Gábor Stefanik
2011-08-16 21:40 ` Gábor Stefanik
2011-08-17 5:41 ` Pekka Enberg [this message]
2011-08-17 19:15 ` Akshay Joshi
2011-08-17 19:17 ` Akshay Joshi
2011-08-17 21:08 ` Dan Carpenter
2011-08-16 21:43 ` Dan Carpenter
2011-08-17 0:19 ` Akshay Joshi
2011-08-16 0:24 ` [PATCH 5/9] Staging: Winbond: Fix spacing issues for spaces before tabs Akshay Joshi
2011-08-16 5:43 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 6/9] Staging: Winbond: Remove spacing issues related to pointers Akshay Joshi
2011-08-16 5:45 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 7/9] Staging: Winbond: Fix parentheses in returns Akshay Joshi
2011-08-16 5:45 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 8/9] Staging: Winbond: Use tabs instead of spaces for indents Akshay Joshi
2011-08-16 5:46 ` Pekka Enberg
2011-08-16 0:24 ` [PATCH 9/9] Staging: Winbond: Reposition a curly bracket Akshay Joshi
2011-08-16 5:46 ` Pekka Enberg
2011-08-16 5:41 ` [PATCH 1/9] Staging: Winbond: Fix case statements in wb35reg.c Pekka Enberg
2011-08-23 22:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4B54A4.4040203@kernel.org \
--to=penberg@kernel.org \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@suse.de \
--cc=karthigan.srinivasan2@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=me@akshayjoshi.com \
--cc=netrolller.3d@gmail.com \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.