From: Jaehoon Chung <jh80.chung@samsung.com>
To: Jaehoon Chung <jh80.chung@samsung.com>
Cc: Seungwon Jeon <tgih.jun@samsung.com>,
linux-mmc@vger.kernel.org, 'Chris Ball' <cjb@laptop.org>,
'Kyungmin Park' <kyungmin.park@samsung.com>,
'Chuanxiao Dong' <chuanxiao.dong@intel.com>,
'Hanumath Prasad' <hanumath.prasad@stericsson.com>
Subject: Re: [RFC PATCH] mmc: support background operation
Date: Wed, 17 Aug 2011 17:30:39 +0900 [thread overview]
Message-ID: <4E4B7C2F.9090304@samsung.com> (raw)
In-Reply-To: <4E4B7825.9030608@samsung.com>
Hi
In eMMC spec, if set BKOPS_SUPPORT bit in ext_csd,
BKOPS_EN, BKOPS_STATUS, BKOPS_START and URGENT_BKOPS are supported for default.
So need not to send switch-command for BKOPS_EN when set BKOPS_SUPPORT bit.
Thanks,
Jaehoon Chung
>> There is no code for enabling BKOPS_EN?
>> If host want to handle background operation manually, it needs.
>
> Sorry, this code is my mistake...maybe duplicated the HPI patch..
> You means maybe need this code..
> /*
> + * Enable BKOPS feature (if supported)
> + */
> + if (card->ext_csd.bkops != NULL) {
> + /*
> + * If card supported BKOPS, default set BKOPS_EN bit.
> + * But ensure to enable bkops, need to check enable bit
> + */
> + if (!card->ext_csd.bkops_en) {
> + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> + EXT_CSD_BKOPS_EN, 1, 0);
> + if (err && err != -EBADMSG)
> + goto free_card;
> +
> + if (err) {
> + printk(KERN_ERR "%s: Enabling BKOPS failed\n",
> + mmc_hostname(card->host));
> + err = 0;
> + } else
> + card->ext_csd.bkops_en = 1;
> + }
> + }
> +
>
> I will resend the RFC patch..
>
> Thank you for comment.
>
> Best Regards,
> Jaehoon Chung
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2011-08-17 8:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 11:14 [RFC PATCH] mmc: support background operation Jaehoon Chung
2011-08-16 16:35 ` J Freyensee
2011-08-16 16:43 ` Chris Ball
2011-08-17 4:03 ` Jaehoon Chung
2011-08-17 16:13 ` J Freyensee
2011-08-18 2:11 ` Jaehoon Chung
2011-08-18 3:16 ` J Freyensee
2011-08-17 8:02 ` Seungwon Jeon
2011-08-17 8:13 ` Jaehoon Chung
2011-08-17 8:30 ` Jaehoon Chung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4B7C2F.9090304@samsung.com \
--to=jh80.chung@samsung.com \
--cc=chuanxiao.dong@intel.com \
--cc=cjb@laptop.org \
--cc=hanumath.prasad@stericsson.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-mmc@vger.kernel.org \
--cc=tgih.jun@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.