From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
"device-drivers-devel@blackfin.uclinux.org"
<device-drivers-devel@blackfin.uclinux.org>,
Drivers <Drivers@analog.com>
Subject: Re: [PATCH] IIO: ADC: New driver for AD7190/AD7192/AD7195 4 Channel SPI ADC
Date: Wed, 17 Aug 2011 15:29:02 +0100 [thread overview]
Message-ID: <4E4BD02E.3070801@cam.ac.uk> (raw)
In-Reply-To: <4E4BC687.3050504@analog.com>
>>> + ret = iio_device_register(indio_dev);
>>> + if (ret)
>>> + goto error_unreg_ring;
>>> + regdone = 1;
>> Hmm..
> Anything bad here?
Bad in a sense, but fault of core rather than driver.
I must have written a large musing on that here, then thought I'd
leave it for another day, but forgotten to remove the Hmm... ;)
>
next prev parent reply other threads:[~2011-08-17 14:20 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-12 12:41 [PATCH] IIO: ADC: New driver for AD7190/AD7192/AD7195 4 Channel SPI ADC michael.hennerich
2011-08-12 13:44 ` Jonathan Cameron
2011-08-17 13:47 ` Michael Hennerich
2011-08-17 14:29 ` Jonathan Cameron [this message]
-- strict thread matches above, loose matches on Subject: below --
2011-08-17 15:04 michael.hennerich
2011-08-17 15:31 ` Jonathan Cameron
2011-08-17 15:57 ` Jonathan Cameron
2011-08-18 8:20 ` Hennerich, Michael
2011-08-17 16:05 ` Paul Thomas
2011-08-18 6:41 ` Hennerich, Michael
2011-08-18 17:26 ` Paul Thomas
2011-08-19 7:41 ` Hennerich, Michael
2011-08-26 6:41 ` Paul Thomas
2011-08-26 7:29 ` Hennerich, Michael
2011-08-17 15:29 michael.hennerich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4BD02E.3070801@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=Drivers@analog.com \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.