From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:40759)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qthek-0006bT-T7
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 11:03:52 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qthef-0004LN-9v
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 11:03:46 -0400
Received: from mail-vx0-f173.google.com ([209.85.220.173]:34103)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <rth7680@gmail.com>) id 1Qthef-0004LH-6E
	for qemu-devel@nongnu.org; Wed, 17 Aug 2011 11:03:41 -0400
Received: by vxi32 with SMTP id 32so1007007vxi.4
	for <qemu-devel@nongnu.org>; Wed, 17 Aug 2011 08:03:40 -0700 (PDT)
Sender: Richard Henderson <rth7680@gmail.com>
Message-ID: <4E4BD848.1090609@twiddle.net>
Date: Wed, 17 Aug 2011 08:03:36 -0700
From: Richard Henderson <rth@twiddle.net>
MIME-Version: 1.0
References: <1313407533-25740-1-git-send-email-khansa@kics.edu.pk>
	<1313407533-25740-3-git-send-email-khansa@kics.edu.pk>
	<4E493EAF.3090207@twiddle.net>
	<CAAoJSP5b1qw=aSAt7bhwPER8M_g__KuGsHwgwPLy55eJstKXsA@mail.gmail.com>
In-Reply-To: <CAAoJSP5b1qw=aSAt7bhwPER8M_g__KuGsHwgwPLy55eJstKXsA@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 2/4] Octeon cpu definitions in target-mips
 and Octeon specific changes in set_thread_area syscall
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Khansa Butt <khansa@kics.edu.pk>
Cc: qemu-devel@nongnu.org

On 08/17/2011 12:00 AM, Khansa Butt wrote:
> with out above fix Octeon user mode binary can not be correctly run
> on QEMU. This was the behavior on actual hardware which we noticed
> when we were debugging the user mode binary on Octeon board. (there
> are instructions in user mode ELF of Octeon which read k0 and k1
> values)

So you're running a modified compiler, libc, and kernel as well?

Because if I look in Linux 3.1-rc2, arch/mips/kernel/syscall.c,
set_thread_area and arch/mips/kernel/process.c, copy_thread,
I see no evidence that any mips variant uses k0 or k1 for TLS.

You should keep this change alongside whatever modified runtime
you are using.  It does not belong upstream in QEMU until your
changes are accepted upstream in linux as well.


r~