From: Casey Schaufler <casey@schaufler-ca.com>
To: Eric Paris <eparis@parisplace.org>
Cc: selinux@tycho.nsa.gov, Casey Schaufler <casey@schaufler-ca.com>
Subject: Re: inclusion of selinux.h in cred.h
Date: Wed, 17 Aug 2011 08:34:34 -0700 [thread overview]
Message-ID: <4E4BDF8A.5090703@schaufler-ca.com> (raw)
In-Reply-To: <CACLa4psgw+FzdJb_TUZdCmakeFrQMOVaFynsPYEe_93RHQCSrw@mail.gmail.com>
On 8/17/2011 6:35 AM, Eric Paris wrote:
> On Wed, Aug 17, 2011 at 1:09 AM, Casey Schaufler<casey@schaufler-ca.com> wrote:
>> Is there some reason that linux/selinux.h is
>> #included in linux/cred.h?
>>
>> I've been building kernels with the inclusion
>> commented out and I have encountered no problems.
>>
>> It's not a problem, but I am curious.
> It can be safely moved, but not removed. This was added when
> creds_are_invalid() was implemented in the header, which makes SELinux
> specific calls (see commit ed868a56988464cd31de0302426a5e94d3127f10).
> This function was moved to kernel/cred.c in commit
> 74908a0009eb36054190ab80deb9671014efed96 but the header was not moved
> with it. If you want to send a patch to move the header from cred.h
> to cred.c I think that would make a lot of sense.
Enlightenment. Thank you.
Since creds_are_invalid() only exists under CONFIG_DEBUG_CREDENTIALS
I would expect the include of selinux.h to be under that ifdef as well.
>
> -Eric
>
> --
> This message was distributed to subscribers of the selinux mailing list.
> If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
> the words "unsubscribe selinux" without quotes as the message.
>
--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.
next prev parent reply other threads:[~2011-08-17 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 5:09 inclusion of selinux.h in cred.h Casey Schaufler
2011-08-17 13:35 ` Eric Paris
2011-08-17 15:34 ` Casey Schaufler [this message]
2011-08-17 15:37 ` Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4BDF8A.5090703@schaufler-ca.com \
--to=casey@schaufler-ca.com \
--cc=eparis@parisplace.org \
--cc=selinux@tycho.nsa.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.