From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Price <anprice@redhat.com>
Date: Wed, 17 Aug 2011 17:51:45 +0100
Subject: [Cluster-devel] [PATCH RHEL6] mount.gfs2: Fix mounting of
 regular files with -o loop
In-Reply-To: <1313598779.2697.14.camel@menhir>
References: <1313598335-23096-1-git-send-email-anprice@redhat.com>
	<1313598779.2697.14.camel@menhir>
Message-ID: <4E4BF1A1.5050701@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 17/08/11 17:32, Steven Whitehouse wrote:
> Hi,
>
> Looks good to me. Did you test it with -o remount to be sure it does the
> right thing for that too?

Yep, testing with -o remount looks fine:

(I added the loop option when testing with remount just to check that it 
was completely ignored in the remount case and wasn't doubled up)

[root at rhel6-01 mount]# mount -o rw,loop,noatime sparse-file /mnt
[root at rhel6-01 mount]# mount | grep gfs2
/dev/loop0 on /mnt type gfs2 
(rw,noatime,localflocks,localcaching,loop=/dev/loop0)
[root at rhel6-01 mount]# mount -vv -o remount,ro,loop /mnt
mount /dev/loop0 /mnt
parse_opts: opts = 
"ro,remount,noatime,loop=/dev/loop0,localflocks,localcaching"
   set flag 1 for "ro", flags = 1
   set flag 20 for "remount", flags = 21
   set flag 400 for "noatime", flags = 421
   add extra localflocks
   add extra localcaching
parse_opts: flags = 421
parse_opts: extra = "localflocks,localcaching"
parse_opts: hostdata = ""
parse_opts: lockproto = ""
parse_opts: locktable = ""
mount(2) ok
read_proc_mounts: device = "/dev/loop0"
read_proc_mounts: dm device = "/dev/loop0"
read_proc_mounts: opts = "ro,noatime,localflocks,localcaching"
read_proc_mounts: proc_entry = "/dev/loop0 /mnt gfs2 
ro,noatime,localflocks,localcaching,loop=/dev/loop0 0 0
"
[root at rhel6-01 mount]# mount | grep gfs2
/dev/loop0 on /mnt type gfs2 
(ro,noatime,localflocks,localcaching,loop=/dev/loop0)

Andy