From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0E9B4E01211 for ; Wed, 17 Aug 2011 12:31:07 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga101.fm.intel.com with ESMTP; 17 Aug 2011 12:31:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.68,240,1312182000"; d="scan'208";a="40737203" Received: from unknown (HELO envy.home) ([10.255.14.197]) by fmsmga002.fm.intel.com with ESMTP; 17 Aug 2011 12:31:17 -0700 Message-ID: <4E4C1703.3030804@linux.intel.com> Date: Wed, 17 Aug 2011 12:31:15 -0700 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110707 Thunderbird/5.0 MIME-Version: 1.0 To: Tom Zanussi References: <9391ba93d0385e0768062df5c4c087d9673a827b.1313598804.git.tom.zanussi@intel.com> <0bb19ed262106171280812cbd463b6697e848d4d.1313598804.git.tom.zanussi@intel.com> <4E4BF98A.5090501@linux.intel.com> <1313609193.2394.13.camel@elmorro> In-Reply-To: <1313609193.2394.13.camel@elmorro> Cc: "yocto@yoctoproject.org" Subject: Re: [PATCH 10/12] meta-fri2: make the use of emgd-driver-bin COMMERCIAL X-BeenThere: yocto@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Discussion of all things Yocto List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Aug 2011 19:31:07 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 08/17/2011 12:26 PM, Tom Zanussi wrote: > On Wed, 2011-08-17 at 10:25 -0700, Darren Hart wrote: >> >> On 08/17/2011 09:51 AM, tom.zanussi@intel.com wrote: >>> From: Tom Zanussi >>> >>> The emgd-driver-bin recipe now automatically downloads and installs >>> EMGD using the new click-through-free tarball, but since the binaries >>> still fall under a non-free license, we need to prevent it from being >>> accidentally installed in an image. >>> >>> We therefore make sure it's labeled in the fri2 layer with >>> 'COMMERCIAL_LICENSE'. In order to build an fri2 image, the user >>> now needs to add a 'COMMERCIAL_LICENSE = ""' line to local.conf. >>> >>> Signed-off-by: Tom Zanussi >>> --- >>> meta-fri2/conf/layer.conf | 2 ++ >>> 1 files changed, 2 insertions(+), 0 deletions(-) >>> >>> diff --git a/meta-fri2/conf/layer.conf b/meta-fri2/conf/layer.conf >>> index 261cccc..eb17336 100644 >>> --- a/meta-fri2/conf/layer.conf >>> +++ b/meta-fri2/conf/layer.conf >>> @@ -10,3 +10,5 @@ BBFILES := "${BBFILES} ${LAYERDIR}/recipes-*/*/*.bb \ >>> BBFILE_COLLECTIONS += "fri2" >>> BBFILE_PATTERN_fri2 := "^${LAYERDIR}/" >>> BBFILE_PRIORITY_fri2 = "6" >>> + >>> +COMMERCIAL_LICENSE += "emgd-driver-bin" >> >> Can't this be done in the common emgd driver recipe? Seems wrong to have >> to specify commercial license for recipe in a machine config... A >> different machine could just omit it and the user would not have to add >> COMMERCIAL_LICENSE = "" to their local.conf and it would be fine? >> >> > > I did try that first, but puting it in the layer.conf was the only thing > that worked. I think the same thing could be said for the other recipes > in the COMMERCIAL_LICENSE list in default-distrovars, as well as the > COMMERCIAL_LICENSE = "" override in local.conf, which is always the > answer on the list given whenever people try to use those recipes (none > of this is documented anywhere that I could find either. Now at least > it is for these layers.) Alright, sounds like a bigger project to get it out of the layer.conf and probably something we need to get into the documentation somewhere. This series looks fine to me otherwise. -- Darren Hart Intel Open Source Technology Center Yocto Project - Linux Kernel