From: Oliver Hartkopp <socketcan@hartkopp.net>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: Netdev List <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: [PATCH] fix IBM EMAC driver after rename.
Date: Thu, 18 Aug 2011 08:50:59 +0200 [thread overview]
Message-ID: <4E4CB653.9080907@hartkopp.net> (raw)
In-Reply-To: <20110818061354.GD19739@ozlabs.org>
On 18.08.2011 08:13, Tony Breeds wrote:
> In commit 9aa3283595451ca093500ff0977b106e1f465586 (ehea/ibm*: Move the
> IBM drivers) the IBM_NEW_EMAC* were renames to IBM_EMAC*
>
> The conversion was incomplete so that even if the driver was added to
> the .config it wasn't built, but there were no errors)
>
> This should fix those omissions.
>
(..)
What about renaming of newemac -> emac in this part of the Makefile?
> diff --git a/drivers/net/ethernet/ibm/emac/Makefile b/drivers/net/ethernet/ibm/emac/Makefile
> index 0b5c995..ed6470c 100644
> --- a/drivers/net/ethernet/ibm/emac/Makefile
> +++ b/drivers/net/ethernet/ibm/emac/Makefile
> @@ -2,10 +2,10 @@
> # Makefile for the PowerPC 4xx on-chip ethernet driver
> #
>
> -obj-$(CONFIG_IBM_NEW_EMAC) += ibm_newemac.o
> +obj-$(CONFIG_IBM_EMAC) += ibm_newemac.o
here s/ibm_newemac.o/ibm_emac.o/
>
> ibm_newemac-y := mal.o core.o phy.o
> -ibm_newemac-$(CONFIG_IBM_NEW_EMAC_ZMII) += zmii.o
> -ibm_newemac-$(CONFIG_IBM_NEW_EMAC_RGMII) += rgmii.o
> -ibm_newemac-$(CONFIG_IBM_NEW_EMAC_TAH) += tah.o
> -ibm_newemac-$(CONFIG_IBM_NEW_EMAC_DEBUG) += debug.o
> +ibm_newemac-$(CONFIG_IBM_EMAC_ZMII) += zmii.o
> +ibm_newemac-$(CONFIG_IBM_EMAC_RGMII) += rgmii.o
> +ibm_newemac-$(CONFIG_IBM_EMAC_TAH) += tah.o
> +ibm_newemac-$(CONFIG_IBM_EMAC_DEBUG) += debug.o
and here s/ibm_newemac-/ibm_emac-/ ???
Regards,
Oliver
next prev parent reply other threads:[~2011-08-18 6:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 6:13 [PATCH] fix IBM EMAC driver after rename Tony Breeds
2011-08-18 6:49 ` David Miller
2011-08-19 1:25 ` Tony Breeds
2011-08-19 3:44 ` David Miller
2011-08-19 3:57 ` Tony Breeds
2011-08-19 4:09 ` Joe Perches
2011-08-18 6:50 ` Oliver Hartkopp [this message]
2011-08-19 1:21 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4CB653.9080907@hartkopp.net \
--to=socketcan@hartkopp.net \
--cc=davem@davemloft.net \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=tony@bakeyournoodle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.