All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Egger <Christoph.Egger@amd.com>
To: "xen-devel@lists.xensource.com" <xen-devel@lists.xensource.com>
Subject: [PATCH] nestedhvm: reduce IPIs with nested-on-nested
Date: Thu, 18 Aug 2011 12:04:59 +0200	[thread overview]
Message-ID: <4E4CE3CB.4030407@amd.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 665 bytes --]


In p2m_get_nestedp2m() there is no need to send IPIs via
nestedhvm_vmcx_flushtlb() since p2m_flush_table() already
did that.

Stop sending IPIs to flush the nested-on-nested pagetable
after write operations. Instead flush the TLB only.
This fixes an endless loop of nested page faults after
adding an entry to the nested-on-nested pagetable.

Signed-off-by: Christoph Egger <Christoph.Egger@amd.com>

-- 
---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Einsteinring 24, 85689 Dornach b. Muenchen
Geschaeftsfuehrer: Alberto Bozzo, Andrew Bowd
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

[-- Attachment #2: xen_nh_ipi.diff --]
[-- Type: text/plain, Size: 1028 bytes --]

diff -r ce4768a78051 xen/arch/x86/mm/hap/nested_hap.c
--- a/xen/arch/x86/mm/hap/nested_hap.c	Mon Aug 08 11:36:21 2011 +0200
+++ b/xen/arch/x86/mm/hap/nested_hap.c	Thu Aug 18 11:54:17 2011 +0200
@@ -86,8 +86,10 @@ nestedp2m_write_p2m_entry(struct p2m_dom
 
     old_flags = l1e_get_flags(*p);
     safe_write_pte(p, new);
-    if (old_flags & _PAGE_PRESENT)
-        nestedhvm_vmcx_flushtlb(p2m);
+
+    if ( (old_flags & _PAGE_PRESENT)
+         && (level == 1 || (level == 2 && (old_flags & _PAGE_PSE))) )
+            flush_tlb_mask(&p2m->p2m_dirty_cpumask);
     
     paging_unlock(d);
 }
diff -r ce4768a78051 xen/arch/x86/mm/p2m.c
--- a/xen/arch/x86/mm/p2m.c	Mon Aug 08 11:36:21 2011 +0200
+++ b/xen/arch/x86/mm/p2m.c	Thu Aug 18 11:54:17 2011 +0200
@@ -1164,7 +1164,6 @@ p2m_get_nestedp2m(struct vcpu *v, uint64
     p2m->cr3 = cr3;
     nv->nv_flushp2m = 0;
     hvm_asid_flush_vcpu(v);
-    nestedhvm_vmcx_flushtlb(p2m);
     cpu_set(v->processor, p2m->p2m_dirty_cpumask);
     p2m_unlock(p2m);
     nestedp2m_unlock(d);

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

             reply	other threads:[~2011-08-18 10:04 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-18 10:04 Christoph Egger [this message]
2011-08-18 13:16 ` [PATCH] nestedhvm: reduce IPIs with nested-on-nested Tim Deegan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4CE3CB.4030407@amd.com \
    --to=christoph.egger@amd.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.