From: Chase Douglas <chase.douglas@canonical.com>
To: Jaikumar Ganesh <jaikumarg@android.com>
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] HID: magicmouse: ignore 'ivalid report id' while switching modes
Date: Thu, 18 Aug 2011 09:48:47 -0700 [thread overview]
Message-ID: <4E4D426F.607@canonical.com> (raw)
In-Reply-To: <CAA8bQNjQ2s4EY=2r455z-3r7yyV0uwSjhQ6m5g2+TCyMRvu0sQ@mail.gmail.com>
On 08/18/2011 09:36 AM, Jaikumar Ganesh wrote:
> Hi Chase
>
> On Thu, Aug 18, 2011 at 9:25 AM, Chase Douglas
> <chase.douglas@canonical.com <mailto:chase.douglas@canonical.com>> wrote:
>
> On 08/17/2011 12:59 PM, Jaikumar Ganesh wrote:
> > From: Jiri Kosina <jkosina@suse.cz <mailto:jkosina@suse.cz>>
> >
> > 23746a introduced this commit but was reverted in c3a492.
> > The trackpad uses report Ids which are not present in the
> > report descriptor. These reports ids are not documented
> > anywhere. There are devices in the market (Apple magic tracpkad,
> > BT version 2.0 is one such device) with the same device id,
> > which fail when we use 0xd7 as the report id. So we need the EIO
> > change of 23746a as a failsafe to work with these devices.
> >
> > Original Author: Jiri Kosina <jkosina@suse.cz
> <mailto:jkosina@suse.cz>>
> >
> > Signed-off-by: Jaikumar Ganesh <jaikumarg@android.com
> <mailto:jaikumarg@android.com>>
>
> I worry this may just be papering over a bug elsewhere in the system
> again. I'm going to try to git bisect this today.
>
>
> The original commit explains in detail why it used to work before, so
> its not a regression in that sense. The commit was present in 2.6.39
> stable tree too but was reverted in 3.0 tree.
It was reverted because it was papering over a bug in the bluetooth
stack, and when that bug was fixed this commit broke things again.
I've determined that there's a bug between Ubuntu's 3.0-1.2 and 3.0-2.3
kernels. There does not appear to be any Ubuntu specific patches that
went in between those versions that would affect this, but there was a
rebase from upstream 3.0-rc3 to 3.0-rc4. There is likely a bug
introduced sometime in there.
I'll be digging deeper...
-- Chase
next prev parent reply other threads:[~2011-08-18 16:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 19:59 [PATCH] HID: magicmouse: ignore 'ivalid report id' while switching modes Jaikumar Ganesh
2011-08-18 16:25 ` Chase Douglas
[not found] ` <CAA8bQNjQ2s4EY=2r455z-3r7yyV0uwSjhQ6m5g2+TCyMRvu0sQ@mail.gmail.com>
2011-08-18 16:48 ` Chase Douglas [this message]
2011-08-18 19:32 ` Chase Douglas
2011-08-18 19:45 ` Jaikumar Ganesh
2011-08-23 8:53 ` Jiri Kosina
2011-08-23 18:17 ` Jaikumar Ganesh
2011-08-25 12:22 ` Jiri Kosina
2011-08-24 15:13 ` Chase Douglas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4D426F.607@canonical.com \
--to=chase.douglas@canonical.com \
--cc=jaikumarg@android.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.