All of lore.kernel.org
 help / color / mirror / Atom feed
From: Harald Hoyer <harald-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
To: John Reiser <jreiser-Po6cBsTGB2ZWk0Htik3J/w@public.gmane.org>
Cc: initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: build initramfs: uncontrolled LD_LIBRARY_PATH
Date: Fri, 19 Aug 2011 08:07:45 +0200	[thread overview]
Message-ID: <4E4DFDB1.9090203@redhat.com> (raw)
In-Reply-To: <4E4DDD15.30202-Po6cBsTGB2ZWk0Htik3J/w@public.gmane.org>

On 19.08.2011 05:48, John Reiser wrote:
> dracut uses ldd when building an initramfs, but I cannot find where
> dracut controls LD_LIBRARY_PATH during the build.  Thus I do not trust
> the results of ldd.  The string "LD_LIBRARY_PATH" does not appear
> in the dracut source tree, there is no use of "env -i", dracut is
> not setuid, etc.
> 
> At a minimum, the built initramfs could fail to satisfy some DT_NEEDED
> entry during boot, leading to a crash.  Some soname was satisfied by
> a library in a non-standard directory on the build-time LD_LIBRARY_PATH,
> and was copied into that non-standard directory of the initramfs, but is
> not findable using the boot-time (default standard) path list.
> 
> That might be the worst, because all users of the initramfs (namely:
> booting only) do control LD_LIBRARY_PATH, so there might be "no possibility"
> of substituting an actual non-standard library.  However, it would be
> safer to control LD_LIBRARY_PATH while building initramfs, or at least
> document why not.
> 

good find!

diff --git a/dracut b/dracut
index cf27b23..dfa71a1 100755
--- a/dracut
+++ b/dracut
@@ -265,6 +265,7 @@ fi

 PATH=/sbin:/bin:/usr/sbin:/usr/bin
 export PATH
+unset LD_LIBRARY_PATH

 [[ $debug ]] && {
     export PS4='${BASH_SOURCE}@${LINENO}(${FUNCNAME[0]}): ';

  parent reply	other threads:[~2011-08-19  6:07 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19  3:48 build initramfs: uncontrolled LD_LIBRARY_PATH John Reiser
     [not found] ` <4E4DDD15.30202-Po6cBsTGB2ZWk0Htik3J/w@public.gmane.org>
2011-08-19  6:07   ` Harald Hoyer [this message]
     [not found]     ` <4E4DFDB1.9090203-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2011-08-19 16:18       ` John Reiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4DFDB1.9090203@redhat.com \
    --to=harald-h+wxahxf7alqt0dzr+alfa@public.gmane.org \
    --cc=initramfs-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=jreiser-Po6cBsTGB2ZWk0Htik3J/w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.