From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] iio: capfun: fix - mask must be type u64
Date: Fri, 19 Aug 2011 11:26:19 +0100 [thread overview]
Message-ID: <4E4E3A4B.7040804@cam.ac.uk> (raw)
In-Reply-To: <1313668903-18115-1-git-send-email-michael.hennerich@analog.com>
On 08/18/11 13:01, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> mask must be type u64 otherwise it won't hold a full event code
Fix merged to original patch. Thanks and good spot.
All branches updated and pushed to iio-blue.git
(sorry all, nasty forces rebasing so you'll probably have to create a patch set
of whatever you have on top and rebuild your local tree).
Going to be the case till these patches are in shape I'm afraid.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
> ---
> drivers/staging/iio/iio_core.h | 2 +-
> drivers/staging/iio/industrialio-core.c | 9 +++++----
> 2 files changed, 6 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/iio/iio_core.h b/drivers/staging/iio/iio_core.h
> index 433952b..85ac5b2 100644
> --- a/drivers/staging/iio/iio_core.h
> +++ b/drivers/staging/iio/iio_core.h
> @@ -33,7 +33,7 @@ int __iio_add_chan_devattr(const char *postfix,
> struct device_attribute *attr,
> const char *buf,
> size_t len),
> - int mask,
> + u64 mask,
> bool generic,
> struct device *dev,
> struct list_head *attr_list);
> diff --git a/drivers/staging/iio/industrialio-core.c b/drivers/staging/iio/industrialio-core.c
> index 4aa538f..35e81f8 100644
> --- a/drivers/staging/iio/industrialio-core.c
> +++ b/drivers/staging/iio/industrialio-core.c
> @@ -519,7 +519,7 @@ int __iio_add_chan_devattr(const char *postfix,
> struct device_attribute *attr,
> const char *buf,
> size_t len),
> - int mask,
> + u64 mask,
> bool generic,
> struct device *dev,
> struct list_head *attr_list)
> @@ -643,7 +643,7 @@ static int iio_device_register_sysfs(struct iio_dev *dev_info)
> else
> ret = sysfs_create_group(&dev_info->dev.kobj,
> &iio_base_dummy_group);
> -
> +
> if (ret) {
> dev_err(dev_info->dev.parent,
> "Failed to register sysfs hooks\n");
> @@ -663,7 +663,7 @@ static int iio_device_register_sysfs(struct iio_dev *dev_info)
> if (ret < 0)
> goto error_clear_attrs;
> }
> - if (dev_info->name) {
> + if (dev_info->name) {
> ret = sysfs_add_file_to_group(&dev_info->dev.kobj,
> &dev_attr_name.attr,
> NULL);
> @@ -796,7 +796,8 @@ static ssize_t iio_ev_value_store(struct device *dev,
> static int iio_device_add_event_sysfs(struct iio_dev *dev_info,
> struct iio_chan_spec const *chan)
> {
> - int ret = 0, i, mask = 0;
> + int ret = 0, i;
> + u64 mask = 0;
> char *postfix;
> if (!chan->event_mask)
> return 0;
prev parent reply other threads:[~2011-08-19 10:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-18 12:01 [PATCH] iio: capfun: fix - mask must be type u64 michael.hennerich
2011-08-19 10:26 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E4E3A4B.7040804@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.