From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?w4lyaWMgUGllbA==?= Subject: Re: [PATCH 6/6] Input: elantech - add v3 hardware support Date: Fri, 19 Aug 2011 15:39:09 +0200 Message-ID: <4E4E677D.5000102@tudelft.nl> References: <1313632629-23603-1-git-send-email-jj_ding@emc.com.tw> <1313632629-23603-7-git-send-email-jj_ding@emc.com.tw> <20110818173959.GE28313@thinkpad-t410> <87hb5ddcsa.fsf@emc.com.tw> <20110819121308.GA16386@thinkpad-t410> <4E4E59DD.7000005@tudelft.nl> <20110819125025.GA17925@thinkpad-t410> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from mailservice.tudelft.nl ([130.161.131.5]:45182 "EHLO mailservice.tudelft.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754449Ab1HSNjL (ORCPT ); Fri, 19 Aug 2011 09:39:11 -0400 In-Reply-To: <20110819125025.GA17925@thinkpad-t410> Sender: linux-input-owner@vger.kernel.org List-Id: linux-input@vger.kernel.org To: JJ Ding , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Aaron Huang Tom Lin Op 19-08-11 14:50, Seth Forshee schreef: >> >> Yes, in other words, in the case of v1 or v2, the switch(fingers) >> does nothing if fingers =3D=3D 0. >> >> Maybe you could do put these 3 lines inside a "if (fingers !=3D 0)": >> + input_report_abs(dev, ABS_X, x1); >> + input_report_abs(dev, ABS_Y, y1); >> + elantech_report_semi_mt_data(dev, fingers, x1, y1, x2, y2); > > I don't think elantech_report_semi_mt_data() should be moved inside t= he > condition. It's doing the right thing when fingers is 0. Oh, right, it already tests for this case :-) My mistake. =C3=89ric -- To unsubscribe from this list: send the line "unsubscribe linux-input" = in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755343Ab1HSNjR (ORCPT ); Fri, 19 Aug 2011 09:39:17 -0400 Received: from mailservice.tudelft.nl ([130.161.131.5]:45182 "EHLO mailservice.tudelft.nl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754449Ab1HSNjL (ORCPT ); Fri, 19 Aug 2011 09:39:11 -0400 X-Spam-Flag: NO X-Spam-Score: -22.91 Message-ID: <4E4E677D.5000102@tudelft.nl> Date: Fri, 19 Aug 2011 15:39:09 +0200 From: =?UTF-8?B?w4lyaWMgUGllbA==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:5.0) Gecko/20110814 Thunderbird/5.0 MIME-Version: 1.0 To: JJ Ding , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, Dmitry Torokhov , Aaron Huang , Tom Lin , Daniel Kurtz , Chase Douglas , Henrik Rydberg , Alessandro Rubini Subject: Re: [PATCH 6/6] Input: elantech - add v3 hardware support References: <1313632629-23603-1-git-send-email-jj_ding@emc.com.tw> <1313632629-23603-7-git-send-email-jj_ding@emc.com.tw> <20110818173959.GE28313@thinkpad-t410> <87hb5ddcsa.fsf@emc.com.tw> <20110819121308.GA16386@thinkpad-t410> <4E4E59DD.7000005@tudelft.nl> <20110819125025.GA17925@thinkpad-t410> In-Reply-To: <20110819125025.GA17925@thinkpad-t410> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Op 19-08-11 14:50, Seth Forshee schreef: >> >> Yes, in other words, in the case of v1 or v2, the switch(fingers) >> does nothing if fingers == 0. >> >> Maybe you could do put these 3 lines inside a "if (fingers != 0)": >> + input_report_abs(dev, ABS_X, x1); >> + input_report_abs(dev, ABS_Y, y1); >> + elantech_report_semi_mt_data(dev, fingers, x1, y1, x2, y2); > > I don't think elantech_report_semi_mt_data() should be moved inside the > condition. It's doing the right thing when fingers is 0. Oh, right, it already tests for this case :-) My mistake. Éric