All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Zapolskiy <vz@mleia.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, ben-linux@fluff.org
Subject: Re: [PATCH] dm9000: control debug level of the driver
Date: Fri, 19 Aug 2011 23:26:41 +0300	[thread overview]
Message-ID: <4E4EC701.4020607@mleia.com> (raw)
In-Reply-To: <20110818.220902.1663745747317150778.davem@davemloft.net>

On 19.08.2011 08:09, David Miller wrote:
> From: Vladimir Zapolskiy<vz@mleia.com>
> Date: Mon, 15 Aug 2011 19:38:34 +0300
>
>> This change allows to get driver specific debug messages output
>> setting a default value for db->debug_level. As far as the maximum
>> level of verbosity is too high, it is demoted by default.
>>
>> Signed-off-by: Vladimir Zapolskiy<vz@mleia.com>
>> Cc: Ben Dooks<ben-linux@fluff.org>
>
> I would much rather see this config option eliminated entirely.
>
> The default can be set by the user at kernel boot or module
> load time with command line settings.

This definitely should be an improvement, initially I wanted to fix a 
particular problem, but let's do it even better.

--
With best wishes,
Vladimir

      reply	other threads:[~2011-08-19 20:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-15 16:38 [PATCH] dm9000: control debug level of the driver Vladimir Zapolskiy
2011-08-19  5:09 ` David Miller
2011-08-19 20:26   ` Vladimir Zapolskiy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E4EC701.4020607@mleia.com \
    --to=vz@mleia.com \
    --cc=ben-linux@fluff.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.