From: Richard Henderson <rth@twiddle.net>
To: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [RFC 6/6] isa: improve bus implementation of ebus bridge
Date: Sat, 20 Aug 2011 13:12:04 -0700 [thread overview]
Message-ID: <4E501514.9090508@twiddle.net> (raw)
In-Reply-To: <1313852195-23081-7-git-send-email-hpoussin@reactos.org>
On 08/20/2011 07:56 AM, Hervé Poussineau wrote:
> + memory_region_init(&s->isa_mem_space, "isa-memory", 0x00100000);
> + memory_region_add_subregion(get_system_memory(),
> + APB_PCI_IO_BASE,
> + &s->isa_mem_space);
You should be passing on, or adding this subregion to, the PCI
memory region. Unfortunately, apb_pci.c hasn't been converted
to the new api yet...
r~
prev parent reply other threads:[~2011-08-20 20:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-20 14:56 [Qemu-devel] [RFC 0/6] ISA bus improvements Hervé Poussineau
2011-08-20 14:56 ` [Qemu-devel] [RFC 1/6] isa: rename isa_bus_new to isa_bus_bridge_init Hervé Poussineau
2011-08-20 14:56 ` [Qemu-devel] [RFC 2/6] isa: rework ISA bus internals, and add ISA bus ops structure Hervé Poussineau
2011-08-20 14:56 ` [Qemu-devel] [RFC 3/6] isa: add isa_address_space() method Hervé Poussineau
2011-08-20 14:56 ` [Qemu-devel] [RFC 4/6] vga: use " Hervé Poussineau
2011-08-20 14:56 ` [Qemu-devel] [RFC 5/6] isa: improve bus implementation of PIIX3 bridge Hervé Poussineau
2011-08-20 14:56 ` [Qemu-devel] [RFC 6/6] isa: improve bus implementation of ebus bridge Hervé Poussineau
2011-08-20 20:12 ` Richard Henderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E501514.9090508@twiddle.net \
--to=rth@twiddle.net \
--cc=hpoussin@reactos.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.