From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Subject: Re: [PATCH] sound/soc/mxs/mxs-saif.c: add missing kfree Date: Mon, 22 Aug 2011 11:21:04 +0100 Message-ID: <4E522D90.6080805@ti.com> References: <1313820761-12042-3-git-send-email-julia@diku.dk> <20110820134439.GA2266@pengutronix.de> <65EE16ACC360FA4D99C96DC085B3F7722212DF@039-SN1MPN1-001.039d.mgd.msft.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by alsa0.perex.cz (Postfix) with ESMTP id 294F424508 for ; Mon, 22 Aug 2011 12:21:10 +0200 (CEST) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: alsa-devel-bounces@alsa-project.org Errors-To: alsa-devel-bounces@alsa-project.org To: Julia Lawall Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , "linux-kernel@vger.kernel.org" , Mark Brown , "kernel-janitors@vger.kernel.org" , Wolfram Sang , Dong Aisheng-B29396 List-Id: alsa-devel@alsa-project.org On 21/08/11 12:18, Julia Lawall wrote: > From: Julia Lawall > > Move the test on pdev->id before the kzalloc to avoid requiring kfree when > the test fails. This fix was suggested by Wolfram Sang. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier x; > expression E1!=0,E2,E3,E4; > statement S; > iterator I; > @@ > > ( > if (...) { ... when != kfree(x) > when != x = E3 > when != E3 = x > * return ...; > } > ... when != x = E2 > when != I(...,x,...) S > if (...) { ... when != x = E4 > kfree(x); ... return ...; } > ) > // > > Signed-off-by: Julia Lawall > > Acked-by: Liam Girdwood From mboxrd@z Thu Jan 1 00:00:00 1970 From: Liam Girdwood Date: Mon, 22 Aug 2011 10:21:04 +0000 Subject: Re: [PATCH] sound/soc/mxs/mxs-saif.c: add missing kfree Message-Id: <4E522D90.6080805@ti.com> List-Id: References: <1313820761-12042-3-git-send-email-julia@diku.dk> <20110820134439.GA2266@pengutronix.de> <65EE16ACC360FA4D99C96DC085B3F7722212DF@039-SN1MPN1-001.039d.mgd.msft.net> In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Julia Lawall Cc: "alsa-devel@alsa-project.org" , Takashi Iwai , "linux-kernel@vger.kernel.org" , Mark Brown , "kernel-janitors@vger.kernel.org" , Wolfram Sang , Dong Aisheng-B29396 On 21/08/11 12:18, Julia Lawall wrote: > From: Julia Lawall > > Move the test on pdev->id before the kzalloc to avoid requiring kfree when > the test fails. This fix was suggested by Wolfram Sang. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier x; > expression E1!=0,E2,E3,E4; > statement S; > iterator I; > @@ > > ( > if (...) { ... when != kfree(x) > when != x = E3 > when != E3 = x > * return ...; > } > ... when != x = E2 > when != I(...,x,...) S > if (...) { ... when != x = E4 > kfree(x); ... return ...; } > ) > // > > Signed-off-by: Julia Lawall > > Acked-by: Liam Girdwood From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756756Ab1HVKV4 (ORCPT ); Mon, 22 Aug 2011 06:21:56 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:40708 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752461Ab1HVKVt (ORCPT ); Mon, 22 Aug 2011 06:21:49 -0400 Message-ID: <4E522D90.6080805@ti.com> Date: Mon, 22 Aug 2011 11:21:04 +0100 From: Liam Girdwood User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.18) Gecko/20110617 Lightning/1.0b2 Thunderbird/3.1.11 MIME-Version: 1.0 To: Julia Lawall CC: Dong Aisheng-B29396 , Wolfram Sang , "kernel-janitors@vger.kernel.org" , Mark Brown , Jaroslav Kysela , Takashi Iwai , "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] sound/soc/mxs/mxs-saif.c: add missing kfree References: <1313820761-12042-3-git-send-email-julia@diku.dk> <20110820134439.GA2266@pengutronix.de> <65EE16ACC360FA4D99C96DC085B3F7722212DF@039-SN1MPN1-001.039d.mgd.msft.net> In-Reply-To: Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/08/11 12:18, Julia Lawall wrote: > From: Julia Lawall > > Move the test on pdev->id before the kzalloc to avoid requiring kfree when > the test fails. This fix was suggested by Wolfram Sang. > > A simplified version of the semantic match that finds this problem is as > follows: (http://coccinelle.lip6.fr/) > > // > @@ > identifier x; > expression E1!=0,E2,E3,E4; > statement S; > iterator I; > @@ > > ( > if (...) { ... when != kfree(x) > when != x = E3 > when != E3 = x > * return ...; > } > ... when != x = E2 > when != I(...,x,...) S > if (...) { ... when != x = E4 > kfree(x); ... return ...; } > ) > // > > Signed-off-by: Julia Lawall > > Acked-by: Liam Girdwood