From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"patches@opensource.wolfsonmicro.com"
<patches@opensource.wolfsonmicro.com>, Liam Girdwood <lrg@ti.cm>
Subject: Re: [PATCH] ASoC: Clear any outstanding WM8962 FLL lock completions before waiting
Date: Mon, 22 Aug 2011 11:38:43 +0100 [thread overview]
Message-ID: <4E5231B3.3040806@ti.com> (raw)
In-Reply-To: <1313943559-13993-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 21/08/11 17:19, Mark Brown wrote:
> Ensure that we don't spuriously trigger early.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> sound/soc/codecs/wm8962.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
>
> diff --git a/sound/soc/codecs/wm8962.c b/sound/soc/codecs/wm8962.c
> index c9e07aa..d2db512 100644
> --- a/sound/soc/codecs/wm8962.c
> +++ b/sound/soc/codecs/wm8962.c
> @@ -2356,6 +2356,8 @@ static int sysclk_event(struct snd_soc_dapm_widget *w,
> switch (event) {
> case SND_SOC_DAPM_PRE_PMU:
> if (fll) {
> + try_wait_for_completion(&wm8962->fll_lock);
> +
> snd_soc_update_bits(codec, WM8962_FLL_CONTROL_1,
> WM8962_FLL_ENA, WM8962_FLL_ENA);
> if (wm8962->irq) {
> @@ -3456,6 +3458,8 @@ static int wm8962_set_fll(struct snd_soc_codec *codec, int fll_id, int source,
> snd_soc_write(codec, WM8962_FLL_CONTROL_7, fll_div.lambda);
> snd_soc_write(codec, WM8962_FLL_CONTROL_8, fll_div.n);
>
> + try_wait_for_completion(&wm8962->fll_lock);
> +
> snd_soc_update_bits(codec, WM8962_FLL_CONTROL_1,
> WM8962_FLL_FRAC | WM8962_FLL_REFCLK_SRC_MASK |
> WM8962_FLL_ENA, fll1);
Acked-by: Liam Girdwood <lrg@ti.com>
prev parent reply other threads:[~2011-08-22 10:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-21 16:19 [PATCH] ASoC: Clear any outstanding WM8962 FLL lock completions before waiting Mark Brown
2011-08-22 10:38 ` Liam Girdwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5231B3.3040806@ti.com \
--to=lrg@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.cm \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.