All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <aliguori@us.ibm.com>
To: Michael Roth <mdroth@linux.vnet.ibm.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] guest agent: remove g_strcmp0 usage
Date: Mon, 22 Aug 2011 09:42:29 -0500	[thread overview]
Message-ID: <4E526AD5.3000005@us.ibm.com> (raw)
In-Reply-To: <1313095092-25092-1-git-send-email-mdroth@linux.vnet.ibm.com>

On 08/11/2011 03:38 PM, Michael Roth wrote:
> g_strcmp0 isn't in all version of glib 2.0, so don't use it to avoid
> build breakage on older distros.
>
> Signed-off-by: Michael Roth<mdroth@linux.vnet.ibm.com>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   qemu-ga.c |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/qemu-ga.c b/qemu-ga.c
> index 869ee37..e6ccc21 100644
> --- a/qemu-ga.c
> +++ b/qemu-ga.c
> @@ -146,7 +146,7 @@ static void ga_log(const gchar *domain, GLogLevelFlags level,
>       }
>
>       level&= G_LOG_LEVEL_MASK;
> -    if (g_strcmp0(domain, "syslog") == 0) {
> +    if (domain&&  strcmp(domain, "syslog") == 0) {
>           syslog(LOG_INFO, "%s: %s", level_str, msg);
>       } else if (level&  s->log_level) {
>           g_get_current_time(&time);

      parent reply	other threads:[~2011-08-22 14:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-11 20:38 [Qemu-devel] [PATCH 1/2] guest agent: remove g_strcmp0 usage Michael Roth
2011-08-11 20:38 ` [Qemu-devel] [PATCH 2/2] guest agent: remove uneeded dependencies Michael Roth
2011-08-12 14:07   ` Anthony Liguori
2011-08-12 15:11     ` Michael Roth
2011-08-22 14:42 ` Anthony Liguori [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E526AD5.3000005@us.ibm.com \
    --to=aliguori@us.ibm.com \
    --cc=mdroth@linux.vnet.ibm.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.