From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:47888)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QvXOG-0006pX-Rh
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 12:30:21 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QvXOF-0002eH-Kj
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 12:30:20 -0400
Received: from mail-yi0-f45.google.com ([209.85.218.45]:48019)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <anthony@codemonkey.ws>) id 1QvXOF-0002eB-GS
	for qemu-devel@nongnu.org; Mon, 22 Aug 2011 12:30:19 -0400
Received: by yih10 with SMTP id 10so4381874yih.4
	for <qemu-devel@nongnu.org>; Mon, 22 Aug 2011 09:30:19 -0700 (PDT)
Message-ID: <4E528418.50807@codemonkey.ws>
Date: Mon, 22 Aug 2011 11:30:16 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <1313328684-25619-1-git-send-email-flameeyes@flameeyes.eu>
In-Reply-To: <1313328684-25619-1-git-send-email-flameeyes@flameeyes.eu>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Subject: Re: [Qemu-devel] [PATCH] build: list libraries after objects,
 for proper linkage
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: =?UTF-8?B?RGllZ28gRWxpbyBQZXR0ZW7Dsg==?= <flameeyes@flameeyes.eu>
Cc: qemu-devel@nongnu.org

On 08/14/2011 08:31 AM, Diego Elio Pettenò wrote:
> Without this change, when using -Wl,--as-needed with GNU linker, the
> libraries would be discarded.
>
> Signed-off-by: Diego Elio Pettenò<flameeyes@flameeyes.eu>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   libcacard/Makefile |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libcacard/Makefile b/libcacard/Makefile
> index 5cd7594..3ea845f 100644
> --- a/libcacard/Makefile
> +++ b/libcacard/Makefile
> @@ -18,7 +18,7 @@ QEMU_CFLAGS+=-I../
>   libcacard.lib-y=$(addsuffix .lo,$(basename $(libcacard-y)))
>
>   vscclient: $(libcacard-y) $(QEMU_OBJS) vscclient.o
> -	$(call quiet-command,$(CC) $(libcacard_libs) -lrt -o $@ $^,"  LINK  $@")
> +	$(call quiet-command,$(CC) -o $@ $^ $(libcacard_libs) -lrt,"  LINK  $@")
>
>   clean:
>   	rm -f *.o */*.o *.d */*.d *.a */*.a *~ */*~ vscclient *.lo .libs/* *.la *.pc
> @@ -37,7 +37,7 @@ install-libcacard:
>   	@echo "libtool is missing, please install and rerun configure"; exit 1
>   else
>   libcacard.la: $(libcacard.lib-y) $(QEMU_OBJS_LIB)
> -	$(call quiet-command,libtool --mode=link --quiet --tag=CC $(CC) $(libcacard_libs) -lrt -rpath $(libdir) -o $@ $^,"  lt LINK $@")
> +	$(call quiet-command,libtool --mode=link --quiet --tag=CC $(CC) -rpath $(libdir) -o $@ $^ $(libcacard_libs) -lrt,"  lt LINK $@")
>
>   libcacard.pc: $(libcacard_srcpath)/libcacard.pc.in
>   	sed -e 's|@LIBDIR@|$(libdir)|' \