All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Knoth <adi@drcomp.erfurt.thur.de>
To: ALSA development <alsa-devel@alsa-project.org>
Cc: "Robert Steffens" <robert.steffens@iosono-sound.com>,
	"Fredrik Lingvall" <fredrik.lingvall@gmail.com>,
	"Andre Schramm" <andre.schramm@iosono-sound.com>,
	"Jörn Nettingsmeier" <nettings@stackingdwarves.net>
Subject: Re: [RME MADI/RayDAT/AIO/AES] Changing hdspm_config and hdspm_status
Date: Mon, 22 Aug 2011 18:42:38 +0200	[thread overview]
Message-ID: <4E5286FE.60603@drcomp.erfurt.thur.de> (raw)
In-Reply-To: <4E528448.4020902@drcomp.erfurt.thur.de>

On 08/22/11 18:31, Adrian Knoth wrote:

> +		switch (hdspm->io_type) {
> +		case MADI:
> +		  config.card_specific.madi.line_out = hdspm_line_out(hdspm);
> +		  config.card_specific.madi.tms = hdspm_c_tms(hdspm);
> +		  config.card_specific.madi.input_select = hdspm_input_select(hdspm);
> +		  config.card_specific.madi.output_mode = hdspm_tx_64(hdspm);
> +		  config.card_specific.madi.sync_ref = hdspm_pref_sync_ref(hdspm);
> +		  break;
> +
> +		default:
> +		  break;
> +		}

Obviously, the other cards are missing. I can contribute RayDAT, if need
be (since I don't use the config ioctl at all, at least I don't need
it).

Fredrik: Do you still work on your hdspconf patch for hdspm? If so,
you'd probably be affected. Add "case MADIface:" below "case MADI:" to
see if it works.


>  			statusregister =
>  				hdspm_read(hdspm, HDSPM_statusRegister);
> -			status.card_specific.madi.madi_input =
> -				(statusregister & HDSPM_AB_int) ? 1 : 0;

MADI input (BNC/Optical) is a config option.

>  			status.card_specific.madi.channel_format =
> -				(statusregister & HDSPM_TX_64ch) ? 1 : 0;
> +				(statusregister & HDSPM_RX_64ch) ? 1 : 0;

This was simply wrong in the current driver: the status struct should
not tell if we're sending 64ch format, it should inform the user if
we're receiving 64ch on the wire.


Cheers

  reply	other threads:[~2011-08-22 16:42 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-22 16:28 [RME MADI/RayDAT/AIO/AES] Changing hdspm_config and hdspm_status Adrian Knoth
2011-08-22 16:31 ` Adrian Knoth
2011-08-22 16:42   ` Adrian Knoth [this message]
2011-08-23 10:53 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E5286FE.60603@drcomp.erfurt.thur.de \
    --to=adi@drcomp.erfurt.thur.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=andre.schramm@iosono-sound.com \
    --cc=fredrik.lingvall@gmail.com \
    --cc=nettings@stackingdwarves.net \
    --cc=robert.steffens@iosono-sound.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.