All of lore.kernel.org
 help / color / mirror / Atom feed
From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
	<openembedded-core@lists.openembedded.org>
Cc: Koen Kooi <koen@dominion.thruhere.net>
Subject: Re: [PATCH 5/8] fix SDK building due TARGET_ARCH use in installation path
Date: Mon, 22 Aug 2011 14:58:51 -0700	[thread overview]
Message-ID: <4E52D11B.6020603@linux.intel.com> (raw)
In-Reply-To: <7fbda567f12cd48df2dc292b370109681ce39cfb.1313816148.git.otavio@ossystems.com.br>

On 08/19/2011 09:58 PM, Otavio Salvador wrote:
> TARGET_ARCH makes the building too fragile since it changes during
> building of target and nativesdk binaries thus making it difficult to
> handle a proper path for installation of binaries. The fix for it is
> to move it to toolchain tarball name.
>
> Signed-off-by: Otavio Salvador<otavio@ossystems.com.br>
> ---
>   meta/classes/populate_sdk.bbclass |    2 +-
>   meta/conf/bitbake.conf            |    2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/meta/classes/populate_sdk.bbclass b/meta/classes/populate_sdk.bbclass
> index 0f3591b..929f730 100644
> --- a/meta/classes/populate_sdk.bbclass
> +++ b/meta/classes/populate_sdk.bbclass
> @@ -9,7 +9,7 @@ SDKTARGETSYSROOT = "${SDKPATH}/sysroots/${TARGET_SYS}"
>
>   TOOLCHAIN_HOST_TASK ?= "task-sdk-host-nativesdk task-cross-canadian-${TRANSLATED_TARGET_ARCH}"
>   TOOLCHAIN_TARGET_TASK ?= "task-core-standalone-sdk-target task-core-standalone-sdk-target-dbg"
> -TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-toolchain-${DISTRO_VERSION}"
> +TOOLCHAIN_OUTPUTNAME ?= "${SDK_NAME}-${SDK_ARCH}-${TARGET_ARCH}-toolchain-${DISTRO_VERSION}"
>
>   RDEPENDS = "${TOOLCHAIN_TARGET_TASK} ${TOOLCHAIN_HOST_TASK}"
>   DEPENDS = "virtual/fakeroot-native sed-native"
> diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
> index b309516..b5c6696 100644
> --- a/meta/conf/bitbake.conf
> +++ b/meta/conf/bitbake.conf
> @@ -361,7 +361,7 @@ DEPLOY_DIR_TOOLS = "${DEPLOY_DIR}/tools"
>
>   PKGDATA_DIR = "${TMPDIR}/pkgdata/${MULTIMACH_TARGET_SYS}"
>
> -SDK_NAME = "oecore-${SDK_ARCH}-${TARGET_ARCH}"
> +SDK_NAME = "oecore-sdk-${DISTRO}"
>   SDKPATH = "/usr/local/${SDK_NAME}"
>   SDKPATHNATIVE = "${SDKPATH}/sysroots/${SDK_SYS}"
>
This is the same set that has been rejected before.

I think this has been discussed before between Richard and Koen, Koen 
was going to look into a variation that Richard suggested, I am not sure 
if Koen has replied to that email (from back in early July).

Sau!



  reply	other threads:[~2011-08-22 22:03 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-20  4:58 [PATCH 0/8] Pending patches from O.S. Systems tree Otavio Salvador
2011-08-20  4:58 ` [PATCH 1/8] Use OECORE_DISTRO_VERSION instead of POKY_DISTRO_VERSION Otavio Salvador
2011-08-20  4:58 ` [PATCH 2/8] kernel.bbclass: blacklist perf-dbg Otavio Salvador
2011-08-22 18:29   ` Saul Wold
2011-08-22 18:53     ` Otavio Salvador
2011-08-20  4:58 ` [PATCH 3/8] kernel.bbclass: move uboot image generation to a specific class Otavio Salvador
2011-08-20  5:07   ` Bruce Ashfield
2011-08-20  5:12     ` Otavio Salvador
2011-08-20 12:48       ` Bruce Ashfield
2011-08-20 22:14         ` Andrea Adami
2011-08-20  4:58 ` [PATCH 4/8] kernel.bbclass: save kernel image name into $kerneldir Otavio Salvador
2011-08-20  4:58 ` [PATCH 5/8] fix SDK building due TARGET_ARCH use in installation path Otavio Salvador
2011-08-22 21:58   ` Saul Wold [this message]
2011-08-23 11:54     ` Otavio Salvador
2011-08-20  4:58 ` [PATCH 6/8] scripts/runqemu: add support to pass bootparams to kernel Otavio Salvador
2011-08-20  4:58 ` [PATCH 7/8] scripts/runqemu: remove redundant checking Otavio Salvador
2011-08-20  8:54   ` Phil Blundell
2011-08-24 17:00     ` Otavio Salvador
2011-08-20  4:58 ` [PATCH 8/8] scripts/combo-layer: fix configuration file handling Otavio Salvador
2011-08-24  3:56 ` [PATCH 0/8] Pending patches from O.S. Systems tree Saul Wold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E52D11B.6020603@linux.intel.com \
    --to=sgw@linux.intel.com \
    --cc=koen@dominion.thruhere.net \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.