From: Saul Wold <sgw@linux.intel.com>
To: Patches and discussions about the oe-core layer
<openembedded-core@lists.openembedded.org>
Cc: Paul Eggleton <paul.eggleton@linux.intel.com>
Subject: Re: [PATCH 1/1] image.bbclass: remove non-standard -n option from cp command
Date: Tue, 23 Aug 2011 08:12:24 -0700 [thread overview]
Message-ID: <4E53C358.9010002@linux.intel.com> (raw)
In-Reply-To: <3b2374ace44a610af75052498766f9840fb3d615.1314094152.git.paul.eggleton@linux.intel.com>
On 08/23/2011 03:11 AM, Paul Eggleton wrote:
> -n is not a POSIX option and does not work on some systems (e.g. Debian
> Lenny); in any case it is not strictly necessary here, so remove it.
>
> Signed-off-by: Paul Eggleton<paul.eggleton@linux.intel.com>
> ---
> meta/classes/image.bbclass | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/meta/classes/image.bbclass b/meta/classes/image.bbclass
> index 286ae01..bf8b73a 100644
> --- a/meta/classes/image.bbclass
> +++ b/meta/classes/image.bbclass
> @@ -138,7 +138,7 @@ fakeroot do_rootfs () {
> mkdir -p ${IMAGE_ROOTFS}
> mkdir -p ${DEPLOY_DIR_IMAGE}
>
> - cp -n ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOY_DIR_IMAGE}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
> + cp ${COREBASE}/meta/files/deploydir_readme.txt ${DEPLOY_DIR_IMAGE}/README_-_DO_NOT_DELETE_FILES_IN_THIS_DIRECTORY.txt
>
> if [ "${USE_DEVFS}" != "1" ]; then
> for devtable in ${@get_devtable_list(d)}; do
Paul,
Is this in addition to the previous image.bbclass patch you provided?
If so, there are 2 usages of -n in original patch that is merged.
Sau!
next prev parent reply other threads:[~2011-08-23 15:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-23 10:11 [PATCH 0/1] Remove cp -n option as discussed Paul Eggleton
2011-08-23 10:11 ` [PATCH 1/1] image.bbclass: remove non-standard -n option from cp command Paul Eggleton
2011-08-23 15:07 ` Koen Kooi
2011-08-23 15:12 ` Saul Wold [this message]
2011-08-23 15:19 ` Paul Eggleton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E53C358.9010002@linux.intel.com \
--to=sgw@linux.intel.com \
--cc=openembedded-core@lists.openembedded.org \
--cc=paul.eggleton@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.