From: Sergei Shtylyov <sshtylyov@mvista.com>
To: John Crispin <blogic@openwrt.org>
Cc: Ralf Baechle <ralf@linux-mips.org>,
Thomas Langer <thomas.langer@lantiq.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH 1/8] MIPS: lantiq: fix early printk
Date: Wed, 24 Aug 2011 13:15:27 +0400 [thread overview]
Message-ID: <4E54C12F.1000408@mvista.com> (raw)
In-Reply-To: <1314174704-15549-2-git-send-email-blogic@openwrt.org>
Hello.
On 24-08-2011 12:31, John Crispin wrote:
> The code was using a 32bit write operation in the early_printk code. This
> resulted in 3 zero bytes also being written to the serial port. Change the
> memory access to 8bit.
> Signed-off-by: Thomas Langer<thomas.langer@lantiq.com>
> Signed-off-by: John Crispin<blogic@openwrt.org>
> Cc: linux-mips@linux-mips.org
> ---
> .../mips/include/asm/mach-lantiq/xway/lantiq_soc.h | 4 ++++
> arch/mips/lantiq/early_printk.c | 14 ++++++++------
> 2 files changed, 12 insertions(+), 6 deletions(-)
> diff --git a/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h b/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
> index 8a3c6be..e6d1ca0 100644
> --- a/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
> +++ b/arch/mips/include/asm/mach-lantiq/xway/lantiq_soc.h
> @@ -34,6 +34,10 @@
> #define LTQ_ASC1_BASE_ADDR 0x1E100C00
> #define LTQ_ASC_SIZE 0x400
>
> +/* during early_printk no ioremap is possible
> + lets use KSEG1 instead */
The preferred style of multi-line comments is:
/*
* bla
* bla
*/
WBR, Sergei
next prev parent reply other threads:[~2011-08-24 9:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 8:31 [PATCH 0/8] MIPS: lantiq: some fixes and support FALC-ON John Crispin
2011-08-24 8:31 ` [PATCH 1/8] MIPS: lantiq: fix early printk John Crispin
2011-08-24 9:15 ` Sergei Shtylyov [this message]
2011-08-24 8:31 ` [PATCH 2/8] MIPS: lantiq: fix cmdline parsing John Crispin
2011-08-24 8:31 ` [PATCH 3/8] MIPS: lantiq: fix watchdogs timeout handling John Crispin
2011-08-24 8:31 ` [PATCH 4/8] MIPS: lantiq: reorganize xway code John Crispin
2011-08-24 8:31 ` [PATCH 5/8] MIPS: lantiq: make irq.c support the FALC-ON John Crispin
2011-08-24 8:31 ` [PATCH 6/8] MIPS: lantiq: add basic support for FALC-ON John Crispin
2011-08-24 8:31 ` [PATCH 7/8] MIPS: lantiq: add support for FALC-ON GPIOs John Crispin
2011-08-24 8:31 ` [PATCH 8/8] MIPS: lantiq: add support for the EASY98000 evaluation board John Crispin
2011-11-16 13:18 ` [PATCH 0/8] MIPS: lantiq: some fixes and support FALC-ON Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E54C12F.1000408@mvista.com \
--to=sshtylyov@mvista.com \
--cc=blogic@openwrt.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=thomas.langer@lantiq.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.