From: Jonathan Cameron <jic23@cam.ac.uk>
To: Greg KH <greg@kroah.com>
Cc: linux-iio@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] Sysfs group create for empty groups.
Date: Wed, 24 Aug 2011 13:16:37 +0100 [thread overview]
Message-ID: <4E54EBA5.9040103@cam.ac.uk> (raw)
In-Reply-To: <20110823220311.GA15689@kroah.com>
I've dropped lkml on this discussion seeing as it will now be all linux-iio
stuff.
Anyhow, I've put together a patch set that does this on top of iio-blue.git.
Unfortunately it requires changes in a lot of drivers.
Basically you have to do iio_device_register last - after all ring and trigger
registrations (previously it had to be first).
Has the nice side effect of removing the need for that nasty regdone trick
that quite a lot of drivers use.
Sorry all but this will break almost all drivers currently out of tree.
I wasn't too nasty to implement, though it does mean embedding attribute_group
structures in struct iio_dev, struct iio_ring_buffer and struct iio_event_interface
and dynamically allocating the struct attribute pointer arrays + remembering to
free them. That's all in the core though so as long as I haven't messed up shouldn't
effect anyone.
+ now we should get all the right notifications for file creation.
Will post patches once I've done all the driver reorderings as stated above.
Jonathan
next prev parent reply other threads:[~2011-08-24 12:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-17 10:17 [RFC PATCH 0/2] Sysfs group create for empty groups Jonathan Cameron
2011-08-17 10:17 ` [PATCH 1/2] sysfs: Allow for null group pointer in create_group Jonathan Cameron
2011-08-17 10:17 ` [PATCH 2/2] sysfs: Allow for groups with no attributes - grp->attrs = NULL Jonathan Cameron
2011-08-17 16:27 ` [RFC PATCH 0/2] Sysfs group create for empty groups Jonathan Cameron
2011-08-23 0:33 ` Greg KH
2011-08-23 11:01 ` Jonathan Cameron
2011-08-23 19:25 ` Jonathan Cameron
2011-08-23 22:03 ` Greg KH
2011-08-24 12:16 ` Jonathan Cameron [this message]
2011-08-24 15:10 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E54EBA5.9040103@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=greg@kroah.com \
--cc=linux-iio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.