From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33644) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwCql-0001lc-IE for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:46:32 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwCqk-0003I6-NT for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:46:31 -0400 Received: from david.siemens.de ([192.35.17.14]:20809) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwCqk-0003Hz-6Z for qemu-devel@nongnu.org; Wed, 24 Aug 2011 08:46:30 -0400 Message-ID: <4E54F2A2.6000100@siemens.com> Date: Wed, 24 Aug 2011 14:46:26 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1314187627-20975-1-git-send-email-avi@redhat.com> In-Reply-To: <1314187627-20975-1-git-send-email-avi@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] vga: squash build error in vga_update_memory_access() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: qemu-devel@nongnu.org On 2011-08-24 14:07, Avi Kivity wrote: > Newer gcc complains that base and size may be used uninitialized, even though > it is clearly a false warning. Mmh, gcc is getting dumber again. > Silence the warning by indicating to gcc that > the code path triggering the warning cannot happen. > > Signed-off-by: Avi Kivity > --- > hw/vga.c | 2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/hw/vga.c b/hw/vga.c > index 851fd68..b74e6e8 100644 > --- a/hw/vga.c > +++ b/hw/vga.c > @@ -179,6 +179,8 @@ static void vga_update_memory_access(VGACommonState *s) > base = 0xb8000; > size = 0x8000; > break; > + default: > + abort(); > } > region = g_malloc(sizeof(*region)); > memory_region_init_alias(region, "vga.chain4", &s->vram, offset, size); ...or just make the last case default? Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux