From: Avi Kivity <avi@redhat.com>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: Lucas Meneghel Rodrigues <lmr@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful
Date: Wed, 24 Aug 2011 16:06:38 +0300 [thread overview]
Message-ID: <4E54F75E.7090502@redhat.com> (raw)
In-Reply-To: <4E54F66B.40000@codemonkey.ws>
On 08/24/2011 04:02 PM, Anthony Liguori wrote:
>> Too subtle, IMO. I understand that we want to avoid a full qmp parser
>> for one-off unit tests, but using bit fields in the exit code?
>>
>> Perhaps a python script that launches qemu with qmp and -no-shutdown,
>> listens for the guest shutdown event, and prints out the result? That
>> can be easily reused in test scripts.
>
>
> How can the test pass data via shutdown? You would need a scratch
> register of some form I think...
I meant using the port in the patch. Just replace exit() with the
ordinary shutdown path - notifications, and not exiting if -no-shutdown
is requested.
--
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.
prev parent reply other threads:[~2011-08-24 13:06 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 19:31 [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful Anthony Liguori
2011-08-08 19:31 ` [Qemu-devel] [PATCH 2/2] [FYI] coverage test for Linux installs Anthony Liguori
2011-08-08 19:35 ` Anthony Liguori
2011-08-23 15:50 ` Ryan Harper
2011-08-12 13:46 ` [Qemu-devel] [PATCH 1/2] pc: make vgabios exit port more useful Anthony Liguori
2011-08-24 9:47 ` Avi Kivity
2011-08-24 12:38 ` Anthony Liguori
2011-08-24 12:55 ` Avi Kivity
2011-08-24 13:02 ` Anthony Liguori
2011-08-24 13:06 ` Avi Kivity [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E54F75E.7090502@redhat.com \
--to=avi@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=anthony@codemonkey.ws \
--cc=lmr@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.