Re: [PATCH 1/1] x86: fix a bug of wrong return erorr.

[Bruce Ashfield <bruce.ashfield@windriver.com>]

On 11-08-23 10:45 PM, Liming Wang wrote:
> __vdso_clock_gettime should fall back to call vdso_fallback_gettime function
> if no clockid is selected, not just return error.

At a glance, this seems reasonable to me .. and then I
looked a bit more. This is in fact introduced by lttng and
the ENIVAL does look wrong. It's worth checking out the
latest lttng to make sure that this error isn't there as
well. Our 3.0 kernel won't have this bug yet, but I'll
keep an eye out for this during any lttng work.

I'll merge this into the 2.6.37 tree shortly.

Cheers,

Bruce

>
> Signed-off-by: Liming Wang<liming.wang@windriver.com>
> ---
>   arch/x86/vdso/vclock_gettime.c |    2 --
>   1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/vdso/vclock_gettime.c b/arch/x86/vdso/vclock_gettime.c
> index 7bc4815..2365a5b 100644
> --- a/arch/x86/vdso/vclock_gettime.c
> +++ b/arch/x86/vdso/vclock_gettime.c
> @@ -173,8 +173,6 @@ notrace int __vdso_clock_gettime(clockid_t clock, struct timespec *ts)
>   			return do_trace_clock(ts);
>   		case CLOCK_TRACE_FREQ:
>   			return do_trace_clock_freq(ts);
> -		default:
> -			return -EINVAL;
>   		}
>   	return vdso_fallback_gettime(clock, ts);
>   }