From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anthony Liguori Subject: Re: [Qemu-devel] [RFC PATCH v5 0/4] Separate thread for VM migration Date: Wed, 24 Aug 2011 12:19:06 -0500 Message-ID: <4E55328A.8000203@codemonkey.ws> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, pbonzini@redhat.com, mtosatti@redhat.com, quintela@redhat.com To: Umesh Deshpande Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:37144 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752386Ab1HXRTJ (ORCPT ); Wed, 24 Aug 2011 13:19:09 -0400 Received: by gwaa12 with SMTP id a12so1036614gwa.19 for ; Wed, 24 Aug 2011 10:19:09 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 08/23/2011 10:12 PM, Umesh Deshpande wrote: > Following patch series deals with VCPU and iothread starvation during the > migration of a guest. Currently the iothread is responsible for performing the > guest migration. It holds qemu_mutex during the migration and doesn't allow VCPU > to enter the qemu mode and delays its return to the guest. The guest migration, > executed as an iohandler also delays the execution of other iohandlers. > In the following patch series, Can you please include detailed performance data with and without this series? Perhaps runs of migration with jitterd running in the guest. Regards, Anthony Liguori > > The migration has been moved to a separate thread to > reduce the qemu_mutex contention and iohandler starvation. > > Umesh Deshpande (4): > MRU ram block list > migration thread mutex > separate migration bitmap > separate migration thread > > arch_init.c | 38 ++++++++++++---- > buffered_file.c | 75 +++++++++++++++++-------------- > cpu-all.h | 42 +++++++++++++++++ > exec.c | 97 ++++++++++++++++++++++++++++++++++++++-- > migration.c | 122 +++++++++++++++++++++++++++++--------------------- > migration.h | 9 ++++ > qemu-common.h | 2 + > qemu-thread-posix.c | 10 ++++ > qemu-thread.h | 1 + > savevm.c | 5 -- > 10 files changed, 297 insertions(+), 104 deletions(-) > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:33575) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwH6d-0006j1-4o for qemu-devel@nongnu.org; Wed, 24 Aug 2011 13:19:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwH6c-0001LS-0q for qemu-devel@nongnu.org; Wed, 24 Aug 2011 13:19:11 -0400 Received: from mail-gw0-f45.google.com ([74.125.83.45]:37114) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwH6b-0001LO-Tf for qemu-devel@nongnu.org; Wed, 24 Aug 2011 13:19:09 -0400 Received: by gwb19 with SMTP id 19so1175653gwb.4 for ; Wed, 24 Aug 2011 10:19:09 -0700 (PDT) Message-ID: <4E55328A.8000203@codemonkey.ws> Date: Wed, 24 Aug 2011 12:19:06 -0500 From: Anthony Liguori MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [RFC PATCH v5 0/4] Separate thread for VM migration List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Umesh Deshpande Cc: pbonzini@redhat.com, mtosatti@redhat.com, qemu-devel@nongnu.org, kvm@vger.kernel.org, quintela@redhat.com On 08/23/2011 10:12 PM, Umesh Deshpande wrote: > Following patch series deals with VCPU and iothread starvation during the > migration of a guest. Currently the iothread is responsible for performing the > guest migration. It holds qemu_mutex during the migration and doesn't allow VCPU > to enter the qemu mode and delays its return to the guest. The guest migration, > executed as an iohandler also delays the execution of other iohandlers. > In the following patch series, Can you please include detailed performance data with and without this series? Perhaps runs of migration with jitterd running in the guest. Regards, Anthony Liguori > > The migration has been moved to a separate thread to > reduce the qemu_mutex contention and iohandler starvation. > > Umesh Deshpande (4): > MRU ram block list > migration thread mutex > separate migration bitmap > separate migration thread > > arch_init.c | 38 ++++++++++++---- > buffered_file.c | 75 +++++++++++++++++-------------- > cpu-all.h | 42 +++++++++++++++++ > exec.c | 97 ++++++++++++++++++++++++++++++++++++++-- > migration.c | 122 +++++++++++++++++++++++++++++--------------------- > migration.h | 9 ++++ > qemu-common.h | 2 + > qemu-thread-posix.c | 10 ++++ > qemu-thread.h | 1 + > savevm.c | 5 -- > 10 files changed, 297 insertions(+), 104 deletions(-) >