From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Vasanthakumar Thiagarajan <vthiagar@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 1/3] ath6kl: Add initial debugfs changes
Date: Wed, 24 Aug 2011 20:23:59 +0300 [thread overview]
Message-ID: <4E5533AF.4080905@qca.qualcomm.com> (raw)
In-Reply-To: <20110824144433.GC25267@vasanth-laptop>
On 08/24/2011 05:44 PM, Vasanthakumar Thiagarajan wrote:
> On Wed, Aug 24, 2011 at 05:33:30PM +0300, Kalle Valo wrote:
>>
>> Actually do we really need ATH6KL_DEBUGFS? I would think that if both
>> ATH6KL_DEBUG and DEBUG_FS are enabled we should just enable debugfs code
>> in ath6kl. I don't see the need to have separate kconfig option control
>> that.
>
> You are right. We can directly use CONFIG_DEBUG_FS to enable ath6kl
> debugfs functionalities, also as I said, this does not need to
> depend on ATH6KL_DEBUG. One purpose that I can think of introducing
> a config option for debugfs is to reduce the size of the binary,
> may be it is very insignificant.
Yeah, I think we don't need to worry that. The user can always disable
CONFIG_DEBUG_FS if he doesn't want to use debugfs, just disabling
debugfs for ath6kl doesn't make sense.
Kalle
next prev parent reply other threads:[~2011-08-24 17:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 14:25 [PATCH 1/3] ath6kl: Add initial debugfs changes Vasanthakumar Thiagarajan
2011-08-24 14:25 ` [PATCH 2/3] ath6kl: Add debugfs entry to dump target stats Vasanthakumar Thiagarajan
2011-08-24 14:25 ` [PATCH 3/3] ath6kl: Add debugfs file entry to dump credit distribution stats Vasanthakumar Thiagarajan
2011-08-24 14:30 ` [PATCH 1/3] ath6kl: Add initial debugfs changes Vasanthakumar Thiagarajan
2011-08-24 14:33 ` Kalle Valo
2011-08-24 14:44 ` Vasanthakumar Thiagarajan
2011-08-24 17:23 ` Kalle Valo [this message]
2011-08-24 14:39 ` Kalle Valo
2011-08-24 14:46 ` Vasanthakumar Thiagarajan
2011-08-24 17:31 ` Kalle Valo
2011-08-24 14:46 ` Kalle Valo
2011-08-24 14:52 ` Vasanthakumar Thiagarajan
2011-08-24 17:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5533AF.4080905@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
--cc=vthiagar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.