From: Andreas Oberritter <obi@linuxtv.org>
To: Devin Heitmueller <dheitmueller@kernellabs.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] DVB: dvb_frontend: convert semaphore to mutex
Date: Wed, 24 Aug 2011 20:02:38 +0200 [thread overview]
Message-ID: <4E553CBE.8010506@linuxtv.org> (raw)
In-Reply-To: <CAGoCfizk8Ni96yJJq7Q=MGhH_-EgLskYd3SDMJ4w9mAdEPg1mg@mail.gmail.com>
On 24.08.2011 19:54, Devin Heitmueller wrote:
> On Wed, Aug 24, 2011 at 1:33 PM, Andreas Oberritter <obi@linuxtv.org> wrote:
>> Signed-off-by: Andreas Oberritter <obi@linuxtv.org>
>
> This may seem like a silly question, but *why* are you making this
> change? There is no explanation for what prompted it. Is it in
> response to some issue you encountered?
A semaphore with only one unit is nothing but a mutex. Using a mutex
structure decreases memory footprint and improves readability.
> I'm asking because in general dvb_frontend has a fairly complicated
> locking model, and unless there is a compelling reason to make changes
> I would be against it.
The lock is part of fepriv, which is local to dvb_frontend.c. The patch
is really simple.
> In other words, this is a bad place for arbitrary "cleanup patches".
It's impossible to clean up dvb_frontend.c, which looks quite
unmaintained, without touching it.
Regards,
Andreas
next prev parent reply other threads:[~2011-08-24 18:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 17:33 [PATCH 1/2] DVB: dvb_frontend: convert semaphore to mutex Andreas Oberritter
2011-08-24 17:33 ` [PATCH 2/2] DVB: dvb_frontend: check function pointers on reinitialize Andreas Oberritter
2011-08-24 17:54 ` [PATCH 1/2] DVB: dvb_frontend: convert semaphore to mutex Devin Heitmueller
2011-08-24 18:02 ` Andreas Oberritter [this message]
2011-08-24 18:06 ` Devin Heitmueller
2011-08-24 18:08 ` Andreas Oberritter
2011-08-24 18:54 ` Devin Heitmueller
2011-08-26 10:10 ` Andreas Oberritter
2011-09-04 14:00 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E553CBE.8010506@linuxtv.org \
--to=obi@linuxtv.org \
--cc=dheitmueller@kernellabs.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.