From: Tomas Henzl <thenzl@redhat.com>
To: adam radford <aradford@gmail.com>
Cc: linux-scsi@vger.kernel.org, steve.masters@lsi.com,
michael.benz@lsi.com, bo.yang@lsi.com
Subject: Re: [PATCH 1/2] megaraid_sas: Remove the shutdown_controller call
Date: Thu, 25 Aug 2011 10:17:42 +0200 [thread overview]
Message-ID: <4E560526.5060601@redhat.com> (raw)
In-Reply-To: <CAHtARFF1iwy2NR1G01hFqBo2hoYxAbG+0DQ0UJNSS3JO_s5qbg@mail.gmail.com>
On 08/24/2011 10:55 PM, adam radford wrote:
> On Wed, Aug 24, 2011 at 8:35 AM, Tomas Henzl <thenzl@redhat.com> wrote:
>> Remove the call to megasas_shutdown_controller in the megasas_shutdown.
> NACK. The call to megasas_shutdown_controller() should not be removed.
>
> megasas_shutdown_controller() does 3 things:
>
> 1. Cancels pended AEN command in firmware.
> 2. Cancels pended map update command in firmware.
> 3. Fires a MR_DCMD_CTRL_SHUTDOWN to notify firmware there was a clean
> shutdown. Without this, FW will think there was an 'unclean shutdown'
> on the next restart, which will cause rebuilds and other background FW
> activity to kick on every shutdown/reboot.
OK, from what I have seen the problem happens as a response to MR_DCMD_CTRL_SHUTDOWN
(it means we could let the 1+2 pass and remove only the third point),
but nobody wants 'background FW activity...' etc so let s skip patch.
We need to find a better method for this problem.
In the meantime - I've sent two patches, what do you think about the second one?
It solves(hides) the problem too.
Tomas
>
> -Adam
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-08-25 8:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 15:35 [PATCH 0/2] megaraid_sas: Fix an errant command from hw Tomas Henzl
2011-08-24 15:35 ` [PATCH 1/2] megaraid_sas: Remove the shutdown_controller call Tomas Henzl
2011-08-24 20:55 ` adam radford
2011-08-25 8:17 ` Tomas Henzl [this message]
2011-08-26 0:00 ` adam radford
2011-09-05 14:17 ` Tomas Henzl
2011-08-24 15:35 ` [PATCH 2/2] megaraid_sas: Initialize the cmd field to a known value Tomas Henzl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E560526.5060601@redhat.com \
--to=thenzl@redhat.com \
--cc=aradford@gmail.com \
--cc=bo.yang@lsi.com \
--cc=linux-scsi@vger.kernel.org \
--cc=michael.benz@lsi.com \
--cc=steve.masters@lsi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.