From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:45545) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwZgf-0003et-FR for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:09:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwZge-0003Gb-0K for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:09:37 -0400 Received: from fmmailgate02.web.de ([217.72.192.227]:42810) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwZgd-0003Az-Iq for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:09:35 -0400 Message-ID: <4E56498D.8080505@web.de> Date: Thu, 25 Aug 2011 15:09:33 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E48BF2F.7080901@web.de> <4E501243.2090806@mail.berlios.de> <4E54C045.9020007@web.de> <4E562C38.3010908@web.de> <4E564254.2080204@web.de> <4E5647F0.1080806@redhat.com> <4E564909.6010105@us.ibm.com> In-Reply-To: <4E564909.6010105@us.ibm.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig173959B4FD61491475E8721D" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Anthony Liguori Cc: Blue Swirl , TeLeMan , Avi Kivity , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig173959B4FD61491475E8721D Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-08-25 15:07, Anthony Liguori wrote: > On 08/25/2011 08:02 AM, Avi Kivity wrote: >> On 08/25/2011 03:38 PM, Jan Kiszka wrote: >>> >> >>> >> What a mess. Do we really have to go through all 257 packed data >>> structs >>> >> in QEMU and add these MS compat bits to all potentially affected >>> ones? >>> > I prefer to detect -mms-bitfields and remove it in configure. >> >> Can use -mno-ms-bitfields later to override it. >=20 > No, we can't do that. >=20 > The reason glib uses -mms-bitfields is that you need to use it in order= > to call Windows APIs which is does. We will eventually need to do it > anyway. >=20 >> >>> /me too - if that is possible, ie. if the glib bits we are using does= n't >>> require us to apply that mode. Can anyone comment on this? >>> >> >> I'd shy away from that. Even if it works now it may break later. >> >> We should simply avoid bitfields on externally-defined formats; >> meanwhile we can use __attribute__((gcc_struct)) and keep using those = we >> have already. >=20 > +1 We aren't discussing bitfields anymore but essential unaligned (and therefore packed) protocol structs. And I'm not that much worried about going through the few slirp structs but all the other 250 packed ones in entire QEMU. Jan --------------enig173959B4FD61491475E8721D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5WSY0ACgkQitSsb3rl5xQoSACfdEtf7xw08CDzGRD1usA+vI56 dLAAoKiT94r5hXGqnNms65nrdo8LJw7d =/ZDv -----END PGP SIGNATURE----- --------------enig173959B4FD61491475E8721D--