From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([140.186.70.92]:43240)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1QwZkM-00055H-2J
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:13:27 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1QwZkK-0004Dn-SU
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:13:26 -0400
Received: from fmmailgate01.web.de ([217.72.192.221]:55973)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <jan.kiszka@web.de>) id 1QwZkK-0004Di-Ez
	for qemu-devel@nongnu.org; Thu, 25 Aug 2011 09:13:24 -0400
Message-ID: <4E564A72.6080108@web.de>
Date: Thu, 25 Aug 2011 15:13:22 +0200
From: Jan Kiszka <jan.kiszka@web.de>
MIME-Version: 1.0
References: <4E48BF2F.7080901@web.de>
	<4E501243.2090806@mail.berlios.de>	<CAETRQWkDzb0d_uomZeGA2LcvRdo=Fwr3zfN95UCcQELzzzNi+w@mail.gmail.com>	<4E54C045.9020007@web.de>	<CAETRQW=Go8v_uxzY12UJD0xoBZv4Tw-O8kPwQsUaVsCxU6be1w@mail.gmail.com>	<4E562C38.3010908@web.de>	<CAETRQW=SnQxf1UfFg7oxUK2KKW-SGCU=-C6FNMOSmnrd=89uJg@mail.gmail.com>
	<4E564254.2080204@web.de> <4E5648C4.3000604@us.ibm.com>
In-Reply-To: <4E5648C4.3000604@us.ibm.com>
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature";
	boundary="------------enig84F706B61557FE63C89A6938"
Sender: jan.kiszka@web.de
Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <aliguori@us.ibm.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, TeLeMan <geleman@gmail.com>, qemu-devel <qemu-devel@nongnu.org>

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enig84F706B61557FE63C89A6938
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On 2011-08-25 15:06, Anthony Liguori wrote:
> On 08/25/2011 07:38 AM, Jan Kiszka wrote:
>> On 2011-08-25 14:02, TeLeMan wrote:
>>> On Thu, Aug 25, 2011 at 19:04, Jan Kiszka<jan.kiszka@web.de>  wrote:
>>>> What a mess. Do we really have to go through all 257 packed data
>>>> structs
>>>> in QEMU and add these MS compat bits to all potentially affected one=
s?
>>> I prefer to detect -mms-bitfields and remove it in configure.
>>
>> /me too - if that is possible, ie. if the glib bits we are using doesn=
't
>> require us to apply that mode. Can anyone comment on this?
>=20
> So why can't we just #pragma guard all of the slirp bits?  Why are we
> doing it on a per data structure basis?

Packing all structs is not really a good idea, more a last resort.

Jan


--------------enig84F706B61557FE63C89A6938
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAk5WSnIACgkQitSsb3rl5xRF1ACfa5vH15yCt7iUHIpDt/iLH7+q
AZYAn2eHs9giLd5mRB884Ly5q8zuGRc4
=4BK+
-----END PGP SIGNATURE-----

--------------enig84F706B61557FE63C89A6938--