From: Pavel Emelyanov <xemul@parallels.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Zan Lynx <zlynx@acm.org>, Cyrill Gorcunov <gorcunov@gmail.com>,
Nathan Lynch <ntl@pobox.com>, Oren Laadan <orenl@cs.columbia.edu>,
Daniel Lezcano <dlezcano@fr.ibm.com>, Tejun Heo <tj@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Glauber Costa <glommer@parallels.com>,
"containers@lists.osdl.org" <containers@lists.osdl.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Serge Hallyn <serge.hallyn@canonical.com>,
LINUXFS-ML <linux-fsdevel@vger.kernel.org>,
James Bottomley <jbottomley@parallels.com>
Subject: Re: [RFC] fs, proc: Introduce the /proc/<pid>/map_files/ directory v2
Date: Thu, 25 Aug 2011 18:47:47 +0400 [thread overview]
Message-ID: <4E566093.8080707@parallels.com> (raw)
In-Reply-To: <20110825140434.GU25996@one.firstfloor.org>
On 08/25/2011 06:04 PM, Andi Kleen wrote:
> On Thu, Aug 25, 2011 at 10:42:44AM +0400, Pavel Emelyanov wrote:
>> On 08/24/2011 09:36 PM, Andi Kleen wrote:
>>> Pavel Emelyanov <xemul@parallels.com> writes:
>>>>
>>>> No and this is the trick - when you readlink it - it give you trash, but
>>>> when you open one - you get exactly the same file as the map points to.
>>>
>>> Isn't that a minor security hole?
>>>
>>> For example if I pass a file descriptor into a chroot process for
>>> reading, and with this interface you can open it for writing too.
>>> I could see this causing problems.
>>
>> How does it differ from the /proc/pid/fd links?
>
> Those cannot be opened I thought.
Neither can be these links then - I use the same access checks in my code.
> -Andi
>
next prev parent reply other threads:[~2011-08-25 14:47 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 8:53 [RFC] fs, proc: Introduce the /proc/<pid>/map_files/ directory v2 Cyrill Gorcunov
2011-08-24 9:21 ` Pekka Enberg
2011-08-24 9:33 ` Pavel Emelyanov
2011-08-24 9:34 ` Tejun Heo
2011-08-24 9:37 ` Cyrill Gorcunov
2011-08-24 9:41 ` Cyrill Gorcunov
2011-08-24 9:41 ` Cyrill Gorcunov
2011-08-24 9:41 ` Cyrill Gorcunov
2011-08-24 11:18 ` Vasiliy Kulikov
2011-08-24 11:31 ` Cyrill Gorcunov
2011-08-25 8:29 ` Cyrill Gorcunov
2011-08-25 17:01 ` Tejun Heo
2011-08-25 17:05 ` Pavel Emelyanov
2011-08-25 17:21 ` Cyrill Gorcunov
2011-08-25 17:25 ` Pavel Emelyanov
2011-08-25 17:27 ` Tejun Heo
2011-08-25 17:34 ` Cyrill Gorcunov
2011-08-25 17:07 ` Cyrill Gorcunov
2011-08-25 20:54 ` Tejun Heo
2011-08-25 21:12 ` Tejun Heo
2011-08-25 21:34 ` Cyrill Gorcunov
2011-08-25 21:39 ` Tejun Heo
2011-08-26 6:58 ` Cyrill Gorcunov
2011-08-26 11:29 ` Cyrill Gorcunov
2011-08-26 12:28 ` Kirill A. Shutemov
2011-08-26 12:28 ` Kirill A. Shutemov
2011-08-26 12:39 ` Cyrill Gorcunov
2011-08-26 13:16 ` Cyrill Gorcunov
2011-08-26 14:06 ` Tejun Heo
2011-08-26 14:23 ` Kirill A. Shutemov
2011-08-26 14:27 ` Tejun Heo
2011-08-25 17:11 ` Cyrill Gorcunov
2011-08-25 17:36 ` Vasiliy Kulikov
2011-08-25 17:39 ` Cyrill Gorcunov
2011-08-25 17:54 ` Vasiliy Kulikov
2011-08-25 18:13 ` Cyrill Gorcunov
2011-08-24 15:05 ` Zan Lynx
2011-08-24 15:05 ` Zan Lynx
2011-08-24 15:19 ` Pavel Emelyanov
2011-08-24 17:36 ` Andi Kleen
2011-08-24 17:36 ` Andi Kleen
2011-08-25 6:42 ` Pavel Emelyanov
2011-08-25 14:04 ` Andi Kleen
2011-08-25 14:30 ` Cyrill Gorcunov
2011-08-25 14:47 ` Pavel Emelyanov [this message]
2011-08-24 15:22 ` Cyrill Gorcunov
2011-09-13 14:14 ` Pavel Machek
2011-09-13 14:20 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E566093.8080707@parallels.com \
--to=xemul@parallels.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=containers@lists.osdl.org \
--cc=dlezcano@fr.ibm.com \
--cc=glommer@parallels.com \
--cc=gorcunov@gmail.com \
--cc=jbottomley@parallels.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ntl@pobox.com \
--cc=orenl@cs.columbia.edu \
--cc=serge.hallyn@canonical.com \
--cc=tj@kernel.org \
--cc=zlynx@acm.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.