From: Jonathan Cameron <jic23@cam.ac.uk>
To: michael.hennerich@analog.com
Cc: linux-iio@vger.kernel.org,
device-drivers-devel@blackfin.uclinux.org, drivers@analog.com
Subject: Re: [PATCH] iio: imu: adis16400: Avoid using printk facility
Date: Thu, 25 Aug 2011 17:05:23 +0100 [thread overview]
Message-ID: <4E5672C3.6070707@cam.ac.uk> (raw)
In-Reply-To: <1314285832-26879-1-git-send-email-michael.hennerich@analog.com>
On 08/25/11 16:23, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> use dev_info() instead.
>
> Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
merge to iio-blue.git. Feel free to send it directly to Greg if you like though.
As an aside: I've done a fairly substantial reorganization of what was in iio-blue.git master
branch to make it more coherent for merging. Will push out shortly.
Jonathan
> ---
> drivers/staging/iio/imu/adis16400_core.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/staging/iio/imu/adis16400_core.c b/drivers/staging/iio/imu/adis16400_core.c
> index c1ed832..2f0d221 100644
> --- a/drivers/staging/iio/imu/adis16400_core.c
> +++ b/drivers/staging/iio/imu/adis16400_core.c
> @@ -392,7 +392,7 @@ static int adis16400_initial_setup(struct iio_dev *indio_dev)
> if ((prod_id & 0xF000) != st->variant->product_id)
> dev_warn(&indio_dev->dev, "incorrect id");
>
> - printk(KERN_INFO "%s: prod_id 0x%04x at CS%d (irq %d)\n",
> + dev_info(&indio_dev->dev, "%s: prod_id 0x%04x at CS%d (irq %d)\n",
> indio_dev->name, prod_id,
> st->us->chip_select, st->us->irq);
> }
prev parent reply other threads:[~2011-08-25 15:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 15:23 [PATCH] iio: imu: adis16400: Avoid using printk facility michael.hennerich
2011-08-25 16:05 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5672C3.6070707@cam.ac.uk \
--to=jic23@cam.ac.uk \
--cc=device-drivers-devel@blackfin.uclinux.org \
--cc=drivers@analog.com \
--cc=linux-iio@vger.kernel.org \
--cc=michael.hennerich@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.