Re: [PATCH] osd: Kconfig remove wrong FIXME

[Boaz Harrosh <bharrosh@panasas.com>]

On 08/25/2011 06:15 AM, Maxin B John wrote:
> Hi,
> 
> On Mon, Aug 15, 2011 at 10:01 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>>
>> The OSD protocol calls for all kind of security levels that use
>> CRYPTO_HMAC and SH1, but the current code only supports NO_SEC,
>> which does not use any of these.
>>
>> Remove a wrong FIXME that calls for them. Thanks Maxin for
>> reporting on this.
>>
>> CC: "Maxin B. John" <maxin.john@gmail.com>
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>> ---
>>  drivers/scsi/osd/Kconfig |    4 ----
>>  1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
>> index 861b5ce..a070351 100644
>> --- a/drivers/scsi/osd/Kconfig
>> +++ b/drivers/scsi/osd/Kconfig
>> @@ -11,10 +11,6 @@
>>  # it under the terms of the GNU General Public version 2 License as
>>  # published by the Free Software Foundation
>>  #
>> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
>> -#        How is it done properly?
>> -#
>> -
>>  config SCSI_OSD_INITIATOR
>>        tristate "OSD-Initiator library"
>>        depends on SCSI
>> --
>> 1.7.6
>>
> 
> Adding the "Reported-by", if it's not too late:
> 
> Reported-by: Maxin B. John <maxin.john@gmail.com>
> 

Sure I will add it. It's not to late

Boaz

> Cheers,
> Maxin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>