From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:50760) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwdWg-0001YZ-Jc for qemu-devel@nongnu.org; Thu, 25 Aug 2011 13:15:35 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QwdWf-0003fc-Ao for qemu-devel@nongnu.org; Thu, 25 Aug 2011 13:15:34 -0400 Received: from fmmailgate01.web.de ([217.72.192.221]:41207) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QwdWe-0003fU-Ut for qemu-devel@nongnu.org; Thu, 25 Aug 2011 13:15:33 -0400 Message-ID: <4E568330.5020108@web.de> Date: Thu, 25 Aug 2011 19:15:28 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <4E48BF2F.7080901@web.de> <4E501243.2090806@mail.berlios.de> <4E54C045.9020007@web.de> <4E562C38.3010908@web.de> <4E564254.2080204@web.de> <4E5648C4.3000604@us.ibm.com> <4E564A72.6080108@web.de> <4E564E18.7090802@codemonkey.ws> <4E564F06.7040304@web.de> <4E565637.8030909@mail.berlios.de> In-Reply-To: <4E565637.8030909@mail.berlios.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig8550F5504E3500DABC9FA453" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PULL] slirp: Fix issues with -mms-bitfields List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: Blue Swirl , TeLeMan , Anthony Liguori , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig8550F5504E3500DABC9FA453 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 2011-08-25 16:03, Stefan Weil wrote: > As I wrote in my last mail, I compared all structs without and with > -mms-bitfields > using pahole and codiff. The result is in the appended codiff.log. >=20 > About 17 structs changed because of -mms-bitfield. This attribute > modifies not only > structs with bitfield but also packed structs or structs with other > attributes > like TCGPool. >=20 > Jan's patch fixed slirp bitfields. For the remaining cases, I also > thought about > removing -mms-bitfield or setting a pragma in qemu-common.h, but now I > prefer a different solution: replace all __attribute__(packed), > __attribute(__packed__) > by QEMU_PACKED. >=20 > QEMU_PACKED will be a macro defined in compiler.h which sets the attrib= utes > needed (also for w32 with -mms-bitfields). >=20 > Maybe I can send patches with the changes needed next weekend if > everybody agrees > to this solution. Yes, sounds good, specifically as setting gcc_struct in place won't work either due to the fact it's i386-only. Jan --------------enig8550F5504E3500DABC9FA453 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5WgzMACgkQitSsb3rl5xTLLwCgyLc82LhdPVx3UWYkpumVrglq L5UAn0KGqafh4GY21kcbxf/1Pn7K6Kii =y8dZ -----END PGP SIGNATURE----- --------------enig8550F5504E3500DABC9FA453--