From: Boaz Harrosh <bharrosh@panasas.com>
To: git discussion list <git@vger.kernel.org>
Subject: git diff annoyance / feature request
Date: Thu, 25 Aug 2011 12:14:24 -0700 [thread overview]
Message-ID: <4E569F10.8060808@panasas.com> (raw)
git diff has this very annoying miss-fixture where it will state
as hunk header the closest label instead of the function name.
So I get:
@@ -675,9 +670,23 @@ try_again:
}
if (flag) {
- foo();
+ bazz();
}
Instead of what I'd like:
@@ -563,12 +563,7 @@ static int write_exec(struct page_collect *pcol)
}
if (flag) {
- foo();
+ bazz();
}
I mean. The label "try_again" is not at all unique in my file. As a
reader I would like to see where is that code going to. The function
name is a unique file identifier that tells me exactly where the change
is going. The label is not. (It's not freaking BASIC)
I bet all this was just inherited from diff. Would it be accepted if
I send a patch to fix it? What you guys think a goto label makes any
sense at all?
Thanks
Boaz
next reply other threads:[~2011-08-25 19:14 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 19:14 Boaz Harrosh [this message]
2011-08-25 20:00 ` git diff annoyance / feature request Jeff King
2011-08-25 20:40 ` [RFC/PATCH] attr: map builtin userdiff drivers to well-known extensions Jeff King
2011-08-25 21:00 ` Eric Sunshine
2011-08-25 21:06 ` Jeff King
2011-08-25 22:01 ` Boaz Harrosh
2011-08-25 23:44 ` Eric Sunshine
2011-08-26 2:39 ` Jeff King
2011-08-25 22:29 ` Brandon Casey
2011-08-26 2:45 ` Jeff King
2011-08-26 3:58 ` Eric Sunshine
2011-08-26 15:33 ` Brandon Casey
2011-08-25 22:57 ` Junio C Hamano
2011-08-26 2:59 ` Jeff King
2011-08-26 5:52 ` Junio C Hamano
2011-08-26 9:44 ` Thomas Rast
2011-08-27 5:14 ` Alexey Shumkin
2011-08-25 20:27 ` git diff annoyance / feature request Junio C Hamano
2011-08-25 21:58 ` Boaz Harrosh
2011-08-26 9:08 ` Miles Bader
2011-08-26 21:16 ` René Scharfe
2011-08-26 21:37 ` Boaz Harrosh
2011-08-26 21:52 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E569F10.8060808@panasas.com \
--to=bharrosh@panasas.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.