From: anders eriksson <aeriksson@fastmail.fm>
To: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Suresh Siddha <suresh.b.siddha@intel.com>,
Peter Anvin <hpa@zytor.com>, Ingo Molnar <mingo@elte.hu>,
Sergei Shtylyov <sshtylyov@ru.mvista.com>,
linux-kernel@vger.kernel.org
Subject: Re: mtrr failure, 3.1-rc1
Date: Thu, 25 Aug 2011 21:47:35 +0200 [thread overview]
Message-ID: <4E56A6D7.2060603@fastmail.fm> (raw)
In-Reply-To: <20110825164649.GL2803@mtj.dyndns.org>
On 2011-08-25 18:46, Tejun Heo wrote:
> Anders, if your kernel didn't have SMP turned on, can you please
> verify the following patch fixes the problem?
>
> Thanks.
>
> diff --git a/arch/x86/kernel/cpu/mtrr/main.c b/arch/x86/kernel/cpu/mtrr/main.c
> index 08119a3..6b96110 100644
> --- a/arch/x86/kernel/cpu/mtrr/main.c
> +++ b/arch/x86/kernel/cpu/mtrr/main.c
> @@ -149,7 +149,6 @@ struct set_mtrr_data {
> */
> static int mtrr_rendezvous_handler(void *info)
> {
> -#ifdef CONFIG_SMP
> struct set_mtrr_data *data = info;
>
> /*
> @@ -171,7 +170,6 @@ static int mtrr_rendezvous_handler(void *info)
> } else if (mtrr_aps_delayed_init || !cpu_online(smp_processor_id())) {
> mtrr_if->set_all();
> }
> -#endif
> return 0;
> }
>
Tested. Works as expected. Thanks!
-A
next prev parent reply other threads:[~2011-08-25 19:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 7:03 mtrr failure, 3.1-rc1 Anders Eriksson
2011-08-25 15:55 ` Linus Torvalds
2011-08-25 16:46 ` Tejun Heo
2011-08-25 17:21 ` anders eriksson
2011-08-25 17:43 ` Suresh Siddha
2011-08-25 17:43 ` Linus Torvalds
2011-08-25 17:46 ` [PATCH] mtrr: fix UP breakage caused during switch to stop_machine Tejun Heo
2011-08-25 18:00 ` H. Peter Anvin
2011-08-25 18:03 ` Linus Torvalds
2011-08-25 19:47 ` anders eriksson [this message]
2011-08-25 22:10 ` mtrr failure, 3.1-rc1 Bob Tracy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E56A6D7.2060603@fastmail.fm \
--to=aeriksson@fastmail.fm \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sshtylyov@ru.mvista.com \
--cc=suresh.b.siddha@intel.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.