From: Donggeun Kim <dg77.kim@samsung.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH] hwmon: Add driver for EXYNOS4 TMU
Date: Fri, 26 Aug 2011 02:08:07 +0000 [thread overview]
Message-ID: <4E570007.9010508@samsung.com> (raw)
In-Reply-To: <1314260034-10358-1-git-send-email-dg77.kim@samsung.com>
On 2011년 08월 25일 18:17, Jean Delvare wrote:
> Hi Kim,
>
> On Thu, 25 Aug 2011 17:13:54 +0900, Donggeun Kim wrote:
>> This patch allows to read temperature
>> from TMU(Thermal Management Unit) of SAMSUNG EXYNOS4 series of SoC.
>>
>> Signed-off-by: Donggeun Kim <dg77.kim@samsung.com>
>> Signed-off-by: MyungJoo Ham <myungjoo.ham@samsung.com>
>> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
>> ---
>> Documentation/hwmon/exynos4_tmu | 66 ++++
>> drivers/hwmon/Kconfig | 10 +
>> drivers/hwmon/Makefile | 1 +
>> drivers/hwmon/exynos4_tmu.c | 478 +++++++++++++++++++++++++++++
>> include/linux/platform_data/exynos4_tmu.h | 83 +++++
>> 5 files changed, 638 insertions(+), 0 deletions(-)
>> create mode 100644 Documentation/hwmon/exynos4_tmu
>> create mode 100644 drivers/hwmon/exynos4_tmu.c
>> create mode 100644 include/linux/platform_data/exynos4_tmu.h
>
> I don't have time for a full review at the moment, but one thing stood
> out so I'm commenting on that:
>
>> +temp1_alarm shows which interrupt threshold level is met
>> + 1: current temperature exceeds level_0
>> + 10: current temperature exceeds level_1
>> + 100: current temperature exceeds level_2
>> + 1000: current temperature exceeds level_3
>> + RO
>
> This doesn't fit in the standard interface described in
> Documentation/hwmon/sysfs-interface and will thus not be accepted.
>
> Unfortunately the best you can do with the standard interface is 3
> limits, not four. So you'd have:
>
> temp1_max_alarm
> temp1_crit_alarm
> temp1_emergency_alarm
>
> so you'll have to omit one of the levels, or map two levels to one
> alarm file. These alarm files can only return 0 or 1.
>
> BTW it would be great if you could also implement the corresponding
> temp1_max, temp1_crit and temp1_emergency files, at least read-only,
> otherwise the alarm files aren't so useful.
>
I will add the mentioned files in the next patch.
Thank you for your review.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2011-08-26 2:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-25 8:13 [lm-sensors] [PATCH] hwmon: Add driver for EXYNOS4 TMU Donggeun Kim
2011-08-25 9:17 ` Jean Delvare
2011-08-25 16:26 ` Guenter Roeck
2011-08-26 2:08 ` Donggeun Kim [this message]
2011-08-26 2:20 ` Donggeun Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E570007.9010508@samsung.com \
--to=dg77.kim@samsung.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.