From: walter harms <wharms@bfs.de>
To: kernel-janitors@vger.kernel.org
Subject: Re: [patch] dwc3: add a kfree() on error to dwc3_testmode_open()
Date: Fri, 26 Aug 2011 10:46:15 +0000 [thread overview]
Message-ID: <4E577977.3010407@bfs.de> (raw)
In-Reply-To: <20110826092113.GO5975@shale.localdomain>
Am 26.08.2011 12:32, schrieb Sebastian Andrzej Siewior:
> * Dan Carpenter | 2011-08-26 12:21:13 [+0300]:
>
>> Btw. This function returns -EBUSY on success. Was that really what
>> you want?
>
> At that time yes. The idea was to enable the self-test mode of the core
> and let it do transfers forth and back and see if it works. There is
> also no off switch. I wasn't aware that this piece of code is going to
> merged but now I think we need an off switch.
> Thanks for spotting this.
>
> Sebastian
I assume that is true for the memset() also ?
so they can be remove safely ?
re,
wh
prev parent reply other threads:[~2011-08-26 10:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-26 9:21 [patch] dwc3: add a kfree() on error to dwc3_testmode_open() Dan Carpenter
2011-08-26 9:21 ` Dan Carpenter
[not found] ` <20110826092113.GO5975-z0WHZYlhLlzP0Z7Jsv878P8+0UxHXcjY@public.gmane.org>
2011-08-26 9:43 ` Felipe Balbi
2011-08-26 9:43 ` Felipe Balbi
2011-08-26 10:32 ` Sebastian Andrzej Siewior
2011-08-26 10:32 ` Sebastian Andrzej Siewior
2011-08-26 10:48 ` Felipe Balbi
2011-08-26 10:48 ` Felipe Balbi
2011-08-26 10:46 ` walter harms [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E577977.3010407@bfs.de \
--to=wharms@bfs.de \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.