From: Felix Fietkau <nbd@openwrt.org>
To: Rajkumar Manoharan <rmanohar@qca.qualcomm.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath9k_hw: Set default slottime as 9us
Date: Sat, 27 Aug 2011 09:04:36 +0200 [thread overview]
Message-ID: <4E589704.3090807@openwrt.org> (raw)
In-Reply-To: <20110827065256.GA3082@vmraj-lnx.users.atheros.com>
On 2011-08-27 8:52 AM, Rajkumar Manoharan wrote:
> On Sat, Aug 27, 2011 at 08:27:07AM +0200, Felix Fietkau wrote:
>> On 2011-08-27 7:52 AM, Rajkumar Manoharan wrote:
>> >Initialize 9us slot time as that is what is used mostly
>> >(for non-ERP cases) and also to be in sync with initvals.
>> >
>> >Signed-off-by: Rajkumar Manoharan<rmanohar@qca.qualcomm.com>
>> Why does it matter, mac80211 tells the driver to reconfigure it
>> anyway. Also, why use the stupid ATH9K_SLOT_TIME_* enums? I think we
>> should simply remove those.
>>
> In most of the case, mac80211 set as 9us and also initval uses 9us.
> The what is the problem of setting 9us as default. If you want to
> remove ATH9K_SLOT_TIME_* enums, ath9k should not set slottime till
> it got configured.
I don't see a problem with the change aside from the fact that it should
not make any difference at all, so I don't really see any point to it.
- Felix
next prev parent reply other threads:[~2011-08-27 7:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-27 5:52 [PATCH] ath9k_hw: Set default slottime as 9us Rajkumar Manoharan
2011-08-27 6:27 ` Felix Fietkau
2011-08-27 6:52 ` Rajkumar Manoharan
2011-08-27 7:04 ` Felix Fietkau [this message]
2011-08-27 7:09 ` Rajkumar Manoharan
2011-08-27 7:14 ` Felix Fietkau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E589704.3090807@openwrt.org \
--to=nbd@openwrt.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=rmanohar@qca.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.