From mboxrd@z Thu Jan  1 00:00:00 1970
From: Fabio M. Di Nitto <fdinitto@redhat.com>
Date: Mon, 29 Aug 2011 14:06:09 +0200
Subject: [Cluster-devel] bug in cman/init.d/cman.in?
In-Reply-To: <24E144B8C0207547AD09C467A8259F75377CB457@lisa.maurer-it.com>
References: <24E144B8C0207547AD09C467A8259F75377CB457@lisa.maurer-it.com>
Message-ID: <4E5B80B1.4020708@redhat.com>
List-Id: <cluster-devel.redhat.com>
To: cluster-devel.redhat.com
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit

On 08/29/2011 10:44 AM, Dietmar Maurer wrote:
> * do not overwrite global return status 'rtrn' - use local keyword
> 
> Index: new/cman/init.d/cman.in
> ===================================================================
> --- new.orig/cman/init.d/cman.in	2010-12-02 07:19:35.000000000 +0100
> +++ new/cman/init.d/cman.in	2010-12-23 11:32:12.000000000 +0100
> @@ -46,7 +48,7 @@
>  status()
>  {
>  	pid=$(pidof $1 2>/dev/null)
> -	rtrn=$?
> +	local rtrn=$?
>  	if [ $rtrn -ne 0 ]; then
>  		echo "$1 is stopped"
>  	else
> 
> 

Is this purely semantic or are you actually fixing a bug?

Reading the code, it doesn't look like it makes any difference... but I
might not see it right.

Fabio