From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/2 v4] powerpc/p1023rds: Disable nor flash node and enable nand flash node
Date: Mon, 29 Aug 2011 11:29:06 -0500 [thread overview]
Message-ID: <4E5BBE52.7080800@freescale.com> (raw)
In-Reply-To: <20110829074209.5F19F18C46F8@gemini.denx.de>
On 08/29/2011 02:42 AM, Wolfgang Denk wrote:
> Dear Chunhe Lan,
>
> In message <1314602152-9114-1-git-send-email-Chunhe.Lan@freescale.com> you wrote:
>> In the p1023rds, accessing exclusively nor flash or nand flash device by
>> BR0/OR0.
> ...
>> When booting from nor flash, the status of nor node is null that means it
>> is enabled and the status of nand node is disabled in the default dts file,
>> so do not do anything.
>
> It would be more intuitive to the reader, when the enabled node would
> use an explicit
>
> status = "enabled";
>
>> +#ifdef CONFIG_NAND_U_BOOT
>> + do_fixup_by_path_string(fdt, "nor_flash", "status", "disabled");
>> + do_fixup_by_path_string(fdt, "nand_flash", "status", "okay");
>> +#endif
>
> What does ""okay" mean? This is not documented anywhere.
It is documented in ePAPR and IEEE 1275.
> Is this supposed to mean "enabled"?
Yes, or more specifically, "The device is believed to be operational."
It's generally equivalent to having no status property at all.
> Then please write "enabled"
Please don't redefine well-established standards.
-Scott
next prev parent reply other threads:[~2011-08-29 16:29 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 7:15 [U-Boot] [PATCH 2/2 v4] powerpc/p1023rds: Disable nor flash node and enable nand flash node Chunhe Lan
2011-08-29 7:42 ` Wolfgang Denk
2011-08-29 9:02 ` Chunhe Lan
2011-08-29 11:56 ` Wolfgang Denk
2011-08-29 16:29 ` Scott Wood [this message]
2011-08-29 20:05 ` Wolfgang Denk
2011-08-29 20:23 ` Tabi Timur-B04825
2011-08-30 2:54 ` Chunhe Lan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5BBE52.7080800@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.