From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([140.186.70.92]:54930) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy9Ao-0000sr-L7 for qemu-devel@nongnu.org; Mon, 29 Aug 2011 17:15:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qy9An-0001X0-BJ for qemu-devel@nongnu.org; Mon, 29 Aug 2011 17:15:14 -0400 Received: from fmmailgate03.web.de ([217.72.192.234]:51129) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qy9Am-0001Wt-Lg for qemu-devel@nongnu.org; Mon, 29 Aug 2011 17:15:13 -0400 Message-ID: <4E5C015F.5040809@web.de> Date: Mon, 29 Aug 2011 23:15:11 +0200 From: Jan Kiszka MIME-Version: 1.0 References: <1314564200-6872-1-git-send-email-weil@mail.berlios.de> <1314564200-6872-8-git-send-email-weil@mail.berlios.de> <4E5B660F.1020607@siemens.com> <4E5BD900.3020709@mail.berlios.de> In-Reply-To: <4E5BD900.3020709@mail.berlios.de> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig9935602C9B8CDF94A66ED6FB" Sender: jan.kiszka@web.de Subject: Re: [Qemu-devel] [PATCH 7/7] slirp: Fix packing for w32 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Weil Cc: QEMU Developers This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig9935602C9B8CDF94A66ED6FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2011-08-29 20:22, Stefan Weil wrote: > Am 29.08.2011 12:12, schrieb Jan Kiszka: >> On 2011-08-28 22:43, Stefan Weil wrote: >>> Use QEMU_PACKED to eliminate the effects of compiler option >>> -mms-bitfields. >>> >>> Cc: Jan Kiszka >>> Signed-off-by: Stefan Weil >>> --- >>> slirp/slirp.h | 2 +- >>> 1 files changed, 1 insertions(+), 1 deletions(-) >>> >>> diff --git a/slirp/slirp.h b/slirp/slirp.h >>> index dcf99d5..28a5c03 100644 >>> --- a/slirp/slirp.h >>> +++ b/slirp/slirp.h >>> @@ -199,7 +199,7 @@ struct arphdr { >>> uint32_t ar_sip; /* sender IP address */ >>> unsigned char ar_tha[ETH_ALEN]; /* target hardware address */ >>> uint32_t ar_tip; /* target IP address */ >>> -} __attribute__((packed)); >>> +} QEMU_PACKED; >>> >>> #define ARP_TABLE_SIZE 16 >>> >> >> There are further cases in slirp. Please address them as well. >> >> Jan >=20 > I only addressed those cases which are affected by -mms-bitfields, see > http://lists.gnu.org/archive/html/qemu-devel/2011-08/msg03428.html. >=20 > Other files with __attribute__((packed)) will be handled in separate > patches. OK, but this was not clear from the patch description. >=20 > I don't think that I missed a case which breaks slirp, but if I did, > just tell me the struct name so I can fix it, too. =46rom just looking at the slirp struct, you are likely safe as none should have odd layouts. Jan --------------enig9935602C9B8CDF94A66ED6FB Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/ iEYEARECAAYFAk5cAV8ACgkQitSsb3rl5xRdPgCgxLVZNyMZ+wSPHFUtd1bSQklh NzYAnRvcPn2p8Xw8HsapmvzlHLE3eQGJ =adM5 -----END PGP SIGNATURE----- --------------enig9935602C9B8CDF94A66ED6FB--