Re: [Qemu-devel] [PATCH] main: force enabling of I/O thread

[Jan Kiszka <jan.kiszka@web.de>]

[-- Attachment #1: Type: text/plain, Size: 1410 bytes --]

On 2011-08-29 23:25, Anthony Liguori wrote:
> On 08/29/2011 04:23 PM, Andreas Färber wrote:
>> Am 29.08.2011 um 22:24 schrieb Anthony Liguori:
>>
>>> On 08/29/2011 03:21 PM, Andreas Färber wrote:
>>>> Am 29.08.2011 um 20:03 schrieb Anthony Liguori:
>>>>
>>>>> On 08/22/2011 08:35 AM, Jan Kiszka wrote:
>>>>>> On 2011-08-22 15:24, Anthony Liguori wrote:
>>>>>>> Enabling the I/O thread by default seems like an important part of
>>>>>>> declaring
>>>>>>> 1.0.
>>>>>
>>>>> Given that [1] has been applied now, is there any objections to this
>>>>> patch?
>>>>
>>>> There had been additional patches to fix I/O thread issues on Darwin,
>>>> have any such fixes been applied the last few weeks?
>>>
>>> I don't see any outstanding Darwin patches in my queue so either they
>>> were applied or there were issues with them.
>>
>> Alexandre recalled his series on July 25, I spot neither explanation of
>> what was wrong with it nor a v2. Hope he'll explain.
> 
> If there's uncertainty, I'd prefer to enable it sooner than later.  This
> is a key 1.0 feature IMHO and I'd prefer to have more time to work
> through any issues.

What about making --enable-io-thread default as an intermediate step?
That would leave --disable-io-thread as temporary workaround until all
issues are fixed. The latter could generate a big fat warning that this
mode will be removed before 1.0.

Jan


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]