From: David Daney <david.daney@cavium.com>
To: "Kevin D. Kissell" <kevink@paralogos.com>,
Ralf Baechle <ralf@linux-mips.org>
Cc: "Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS
Date: Mon, 29 Aug 2011 17:14:26 -0700 [thread overview]
Message-ID: <4E5C2B62.9040007@cavium.com> (raw)
In-Reply-To: <4E5C26D4.3000906@paralogos.com>
On 08/29/2011 04:55 PM, Kevin D. Kissell wrote:
> I submitted that exact patch (David's more minimal version) in December
> 2010 (and I did test it). Did it not take?
Evidently not. Perhaps Ralf will see fit to commit it this time.
> See the thread "SMTC
> support status in latest git head". The patch went out on December 24
> (why I was spending my Christmas Eve fixing MIPS Linux is another
> question... :op )
>
... one which I will not attempt to address.
David Daney.
> Kevin K.
>
> On 08/29/11 16:45, David Daney wrote:
>> On 08/29/2011 04:20 PM, Edgar E. Iglesias wrote:
>>> Hi,
>>>
>>> Commit 362e696428590f7d0a5d0971a2d04b0372a761b8
>>> reorders a bunch of insns to improve the flow of the pipeline but
>>> for MT_SMTC kernels, AFAICT, the saving of CP0_STATUS seems wrong.
>>
>> Indeed.
>>
>>>
>>> Am I missing something?
>>>
>>
>> It does look like in the MIPS_MT_SMTC case we are clobbering the value
>> in v1.
>>
>>> If not here is a patch, tested with qemu.
>>>
>>
>> How about the attached completely untested one instead?
>>
>> David Daney
>
>
next prev parent reply other threads:[~2011-08-30 0:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 23:20 [PATCH] MIPS: SMTC: Correct saving of CP0_STATUS Edgar E. Iglesias
2011-08-29 23:45 ` David Daney
2011-08-29 23:45 ` David Daney
2011-08-29 23:53 ` David Daney
2011-08-29 23:55 ` Kevin D. Kissell
2011-08-30 0:14 ` David Daney [this message]
2011-08-30 0:35 ` Kevin D. Kissell
2011-08-30 11:16 ` Edgar E. Iglesias
2011-08-30 16:54 ` Kevin D. Kissell
2011-09-14 15:12 ` Ralf Baechle
2011-09-14 18:20 ` Kevin D. Kissell
2011-08-30 5:57 ` Edgar E. Iglesias
2011-09-15 16:00 ` Ralf Baechle
2011-09-17 1:23 ` Edgar E. Iglesias
2011-09-17 2:00 ` Ralf Baechle
2011-09-17 2:08 ` Edgar E. Iglesias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5C2B62.9040007@cavium.com \
--to=david.daney@cavium.com \
--cc=edgar.iglesias@gmail.com \
--cc=kevink@paralogos.com \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.