From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Jouni Malinen <jouni@qca.qualcomm.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 07/20] ath6kl: Implement mgmt_tx
Date: Tue, 30 Aug 2011 12:23:04 +0300 [thread overview]
Message-ID: <4E5CABF8.901@qca.qualcomm.com> (raw)
In-Reply-To: <1314620641-24257-8-git-send-email-jouni@qca.qualcomm.com>
On 08/29/2011 03:23 PM, Jouni Malinen wrote:
> +static int ath6kl_mgmt_tx(struct wiphy *wiphy, struct net_device *dev,
> + struct ieee80211_channel *chan, bool offchan,
> + enum nl80211_channel_type channel_type,
> + bool channel_type_valid, unsigned int wait,
> + const u8 *buf, size_t len, u64 *cookie)
> +{
> + struct ath6kl *ar = ath6kl_priv(dev);
> + u32 id;
> +
> + id = ar->send_action_id++;
> + if (id == 0)
> + id = ar->send_action_id++;
> +
> + *cookie = id;
> + return ath6kl_wmi_send_action_cmd(ar->wmi, id, chan->center_freq, wait,
> + buf, len);
> +}
I don't understand the "if (id == 0)" check. It would be nice to get a
comment giving some background info about the situation.
Kalle
next prev parent reply other threads:[~2011-08-30 9:23 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 12:23 [PATCH 00/20] ath6kl: AP mode and P2P Jouni Malinen
2011-08-29 12:23 ` [PATCH 01/20] ath6kl: Add functionality for starting AP mode Jouni Malinen
2011-08-30 5:47 ` Raja Mani
2011-08-30 8:40 ` Jouni Malinen
2011-08-30 8:49 ` Kalle Valo
2011-08-30 10:38 ` Jouni Malinen
2011-08-30 9:10 ` Raja Mani
2011-08-30 9:02 ` Kalle Valo
2011-08-30 14:03 ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 02/20] ath6kl: Fix AP mode (Re)AssocReq IE processing Jouni Malinen
2011-08-29 12:23 ` [PATCH 03/20] ath6kl: Delay initial group key setup in AP mode Jouni Malinen
2011-08-29 12:23 ` [PATCH 04/20] ath6kl: Use change_station() to authorize/unauthorize STAs Jouni Malinen
2011-08-30 9:06 ` Kalle Valo
2011-08-30 14:09 ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 05/20] ath6kl: Add new WMI commands and events for P2P Jouni Malinen
2011-08-29 12:23 ` [PATCH 06/20] ath6kl: Implement remain_on_channel and cancel_remain_on_channel Jouni Malinen
2011-08-29 12:23 ` [PATCH 07/20] ath6kl: Implement mgmt_tx Jouni Malinen
2011-08-30 9:23 ` Kalle Valo [this message]
2011-08-30 14:13 ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 08/20] ath6kl: Request P2P capabilities during target init Jouni Malinen
2011-08-30 9:51 ` Raja Mani
2011-08-30 14:30 ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 09/20] ath6kl: Add cfg80211 calls for remain-on-channel events Jouni Malinen
2011-08-29 12:23 ` [PATCH 10/20] ath6kl: Use set_appie command to add Probe Request IEs Jouni Malinen
2011-08-30 9:26 ` Kalle Valo
2011-08-30 14:16 ` Jouni Malinen
2011-08-29 12:23 ` [PATCH 11/20] ath6kl: Support channel set request for startscan command Jouni Malinen
2011-08-30 9:33 ` Kalle Valo
2011-08-30 9:51 ` Vasanthakumar Thiagarajan
2011-08-30 11:45 ` Vasanthakumar Thiagarajan
2011-08-30 14:44 ` Jouni Malinen
2011-08-30 10:04 ` Raja Mani
2011-08-30 10:30 ` Kalle Valo
2011-08-30 10:33 ` Raja Mani
2011-08-29 12:23 ` [PATCH 12/20] ath6kl: Report received Probe Request frames to cfg80211 Jouni Malinen
2011-08-29 12:23 ` [PATCH 13/20] ath6kl: Notify cfg80211 of TX status of mgmt_tx frames Jouni Malinen
2011-08-29 12:23 ` [PATCH 14/20] ath6kl: Report received Action frames to cfg80211 Jouni Malinen
2011-08-29 12:23 ` [PATCH 15/20] ath6kl: Advertise supported mgmt_stypes Jouni Malinen
2011-08-29 12:23 ` [PATCH 16/20] ath6kl: Add support for new P2P iftypes in mode changes Jouni Malinen
2011-08-29 12:23 ` [PATCH 17/20] ath6kl: Fix a typo in ath6k context Jouni Malinen
2011-08-29 12:23 ` [PATCH 18/20] ath6kl: Fix default key installation in AP mode Jouni Malinen
2011-08-29 12:24 ` [PATCH 19/20] ath6kl: Do not clear CONNECT bit setting in AP mode for STA disconnect Jouni Malinen
2011-08-29 12:24 ` [PATCH 20/20] ath6kl: Include P2P IE(s) in GO Probe Response depending on request Jouni Malinen
2011-08-30 9:51 ` [PATCH 00/20] ath6kl: AP mode and P2P Kalle Valo
2011-08-30 15:54 ` Jouni Malinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5CABF8.901@qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=jouni@qca.qualcomm.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.