From: Donggeun Kim <dg77.kim@samsung.com>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH v3] hwmon: Add driver for EXYNOS4 TMU
Date: Tue, 30 Aug 2011 10:59:25 +0000 [thread overview]
Message-ID: <4E5CC28D.4050900@samsung.com> (raw)
In-Reply-To: <1314613983-3331-1-git-send-email-dg77.kim@samsung.com>
On 2011년 08월 30일 19:46, Donggeun Kim wrote:
> On 2011년 08월 29일 21:22, R, Durgadoss wrote:
> The read function returns error code (-ENODATA) for abnormal case.
> So, the return type should be 'int'.
>>> +static irqreturn_t exynos4_tmu_irq(int irq, void *id)
>>> +{
>>> + struct exynos4_tmu_data *data = id;
>>
>> I am not sure whether we _must_ cast 'id', as (struct exynos4_tmu_data *)..
>>
> In exynos4_tmu_irq function, 'irq_work' field in 'exynos4_tmu_data' is
> accessed. Thus, it should be casted.
The last sentence is 'Thus, it should not be casted'.
It was my mistake.
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
prev parent reply other threads:[~2011-08-30 10:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-29 10:33 [lm-sensors] [PATCH v3] hwmon: Add driver for EXYNOS4 TMU Donggeun Kim
2011-08-29 12:34 ` R, Durgadoss
2011-08-29 14:11 ` Guenter Roeck
2011-08-29 15:17 ` Guenter Roeck
2011-08-30 10:46 ` Donggeun Kim
2011-08-30 10:59 ` Donggeun Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5CC28D.4050900@samsung.com \
--to=dg77.kim@samsung.com \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.