From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH] ASoC: Allow source specification for CODEC level sysclk
Date: Tue, 30 Aug 2011 17:55:19 +0200 [thread overview]
Message-ID: <4E5D07E7.80305@metafoo.de> (raw)
In-Reply-To: <1314212978-18293-1-git-send-email-broonie@opensource.wolfsonmicro.com>
On 08/24/2011 09:09 PM, Mark Brown wrote:
> Similarly to PLLs/FLLs some modern CODECs provide selectable system clock
> sources. When the clock is the clock for a DAI we do not usually need to
> identify which clock is being configured so can use clk_id for the source
> clock but with CODEC wide system clocks we will need to specify both the
> clock being configured and the source.
>
> Add a source argument to the CODEC driver set_sysclk() operation to
> reflect this. As this operation is not as widely used as the DAI
> set_sysclk() operation the change is not very invasive. We probably
> ought to go and make the same alternation for DAIs at some point.
If we also want to change the DAI driver's set_sysclck we should probably do
this better now than later, because the number of affected drivers is probably
not going to decline.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> include/sound/soc.h | 4 ++--
> sound/soc/codecs/wm9081.c | 4 ++--
> sound/soc/samsung/speyside.c | 2 +-
> sound/soc/soc-core.c | 8 +++++---
The adau1701 and adav80x drivers also implement the CODEC driver set_sysclk.
next prev parent reply other threads:[~2011-08-30 15:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-24 19:09 [PATCH] ASoC: Allow source specification for CODEC level sysclk Mark Brown
2011-08-30 15:55 ` Lars-Peter Clausen [this message]
2011-08-30 15:58 ` Mark Brown
2011-08-31 10:54 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E5D07E7.80305@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=lrg@ti.com \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.